2019-10-23 21:49:14

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] powerpc/spufs: remove set but not used variable 'ctx'

arch/powerpc/platforms/cell/spufs/inode.c:201:22:
warning: variable ctx set but not used [-Wunused-but-set-variable]

It is not used since commit 67cba9fd6456 ("move
spu_forget() into spufs_rmdir()")

Signed-off-by: YueHaibing <[email protected]>
---
arch/powerpc/platforms/cell/spufs/inode.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index 2dd452a..9b1586b 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -198,14 +198,12 @@ static int spufs_fill_dir(struct dentry *dir,

static int spufs_dir_close(struct inode *inode, struct file *file)
{
- struct spu_context *ctx;
struct inode *parent;
struct dentry *dir;
int ret;

dir = file->f_path.dentry;
parent = d_inode(dir->d_parent);
- ctx = SPUFS_I(d_inode(dir))->i_ctx;

inode_lock_nested(parent, I_MUTEX_PARENT);
ret = spufs_rmdir(parent, dir);
--
2.7.4



2019-11-14 09:09:17

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH -next] powerpc/spufs: remove set but not used variable 'ctx'

On Wed, 2019-10-23 at 13:44:23 UTC, YueHaibing wrote:
> arch/powerpc/platforms/cell/spufs/inode.c:201:22:
> warning: variable ctx set but not used [-Wunused-but-set-variable]
>
> It is not used since commit 67cba9fd6456 ("move
> spu_forget() into spufs_rmdir()")
>
> Signed-off-by: YueHaibing <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/35a5c328fcf3493c5adf333d34c1ca6953fe372d

cheers