Some sensors have optical blanking areas, this is, pixels that are
painted and do not account for light, only noise.
These special pixels are very useful for calibrating the sensor, but
should not be displayed on a DEFAULT target.
Acked-by: Sakari Ailus <[email protected]>
Signed-off-by: Ricardo Ribalda Delgado <[email protected]>
---
Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
index f74f239b0510..a69571308a45 100644
--- a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
+++ b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
@@ -38,8 +38,10 @@ of the two interfaces they are used.
* - ``V4L2_SEL_TGT_CROP_DEFAULT``
- 0x0001
- Suggested cropping rectangle that covers the "whole picture".
+ This includes only active pixels and excludes other non-active
+ pixels such as black pixels.
+ - Yes
- Yes
- - No
* - ``V4L2_SEL_TGT_CROP_BOUNDS``
- 0x0002
- Bounds of the crop rectangle. All valid crop rectangles fit inside
@@ -60,8 +62,8 @@ of the two interfaces they are used.
* - ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
- 0x0101
- Suggested composition rectangle that covers the "whole picture".
- - Yes
- No
+ - Yes
* - ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
- 0x0102
- Bounds of the compose rectangle. All valid compose rectangles fit
--
2.23.0
No, I am retarded on friday :)
Sorry about that
On Fri, Oct 25, 2019 at 11:43 AM Sakari Ailus
<[email protected]> wrote:
>
> On Fri, Oct 25, 2019 at 10:56:16AM +0200, Ricardo Ribalda Delgado wrote:
> > Some sensors have optical blanking areas, this is, pixels that are
> > painted and do not account for light, only noise.
> >
> > These special pixels are very useful for calibrating the sensor, but
> > should not be displayed on a DEFAULT target.
> >
> > Acked-by: Sakari Ailus <[email protected]>
> > Signed-off-by: Ricardo Ribalda Delgado <[email protected]>
> > ---
> > Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
> > index f74f239b0510..a69571308a45 100644
> > --- a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
> > +++ b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
> > @@ -38,8 +38,10 @@ of the two interfaces they are used.
> > * - ``V4L2_SEL_TGT_CROP_DEFAULT``
> > - 0x0001
> > - Suggested cropping rectangle that covers the "whole picture".
> > + This includes only active pixels and excludes other non-active
> > + pixels such as black pixels.
> > + - Yes
> > - Yes
> > - - No
> > * - ``V4L2_SEL_TGT_CROP_BOUNDS``
> > - 0x0002
> > - Bounds of the crop rectangle. All valid crop rectangles fit inside
> > @@ -60,8 +62,8 @@ of the two interfaces they are used.
> > * - ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
> > - 0x0101
> > - Suggested composition rectangle that covers the "whole picture".
> > - - Yes
> > - No
> > + - Yes
>
> Was this intended?
>
> v4?
>
> > * - ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
> > - 0x0102
> > - Bounds of the compose rectangle. All valid compose rectangles fit
>
> --
> Sakari Ailus
Subdev can also have non-active pixels, and using the _DEFAULT targets
we can capture only the active pixels.
Signed-off-by: Ricardo Ribalda Delgado <[email protected]>
---
utils/v4l2-compliance/v4l2-test-subdevs.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/v4l2-compliance/v4l2-test-subdevs.cpp b/utils/v4l2-compliance/v4l2-test-subdevs.cpp
index 29987b31..ec4b9512 100644
--- a/utils/v4l2-compliance/v4l2-test-subdevs.cpp
+++ b/utils/v4l2-compliance/v4l2-test-subdevs.cpp
@@ -395,7 +395,7 @@ struct target_info {
static target_info targets[] = {
{ V4L2_SEL_TGT_CROP, true },
- { V4L2_SEL_TGT_CROP_DEFAULT, false, true },
+ { V4L2_SEL_TGT_CROP_DEFAULT, true, true },
{ V4L2_SEL_TGT_CROP_BOUNDS, true, true },
{ V4L2_SEL_TGT_NATIVE_SIZE, true },
{ V4L2_SEL_TGT_COMPOSE, true },
--
2.23.0
On Fri, Oct 25, 2019 at 10:56:16AM +0200, Ricardo Ribalda Delgado wrote:
> Some sensors have optical blanking areas, this is, pixels that are
> painted and do not account for light, only noise.
>
> These special pixels are very useful for calibrating the sensor, but
> should not be displayed on a DEFAULT target.
>
> Acked-by: Sakari Ailus <[email protected]>
> Signed-off-by: Ricardo Ribalda Delgado <[email protected]>
> ---
> Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
> index f74f239b0510..a69571308a45 100644
> --- a/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
> +++ b/Documentation/media/uapi/v4l/v4l2-selection-targets.rst
> @@ -38,8 +38,10 @@ of the two interfaces they are used.
> * - ``V4L2_SEL_TGT_CROP_DEFAULT``
> - 0x0001
> - Suggested cropping rectangle that covers the "whole picture".
> + This includes only active pixels and excludes other non-active
> + pixels such as black pixels.
> + - Yes
> - Yes
> - - No
> * - ``V4L2_SEL_TGT_CROP_BOUNDS``
> - 0x0002
> - Bounds of the crop rectangle. All valid crop rectangles fit inside
> @@ -60,8 +62,8 @@ of the two interfaces they are used.
> * - ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
> - 0x0101
> - Suggested composition rectangle that covers the "whole picture".
> - - Yes
> - No
> + - Yes
Was this intended?
v4?
> * - ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
> - 0x0102
> - Bounds of the compose rectangle. All valid compose rectangles fit
--
Sakari Ailus