2019-10-25 20:53:24

by James Smart

Subject: [PATCH] lpfc: fix build error of lpfc_debugfs.c for vfree/vmalloc

lpfc_debufs.c was missing include of vmalloc.h when compiled on PPC.

Add missing header.

Signed-off-by: Dick Kennedy <[email protected]>
Signed-off-by: James Smart <[email protected]>
---
drivers/scsi/lpfc/lpfc_debugfs.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
index ab124f7d50d6..6c8effcfc8ae 100644
--- a/drivers/scsi/lpfc/lpfc_debugfs.c
+++ b/drivers/scsi/lpfc/lpfc_debugfs.c
@@ -31,6 +31,7 @@
#include <linux/pci.h>
#include <linux/spinlock.h>
#include <linux/ctype.h>
+#include <linux/vmalloc.h>

#include <scsi/scsi.h>
#include <scsi/scsi_device.h>
--
2.13.7

2019-10-25 21:35:11

by Ewan Milne

Subject: Re: [PATCH] lpfc: fix build error of lpfc_debugfs.c for vfree/vmalloc

On Fri, 2019-10-25 at 11:25 -0700, James Smart wrote:
> lpfc_debufs.c was missing include of vmalloc.h when compiled on PPC.
>
> Add missing header.
>
> Signed-off-by: Dick Kennedy <[email protected]>
> Signed-off-by: James Smart <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_debugfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
> index ab124f7d50d6..6c8effcfc8ae 100644
> --- a/drivers/scsi/lpfc/lpfc_debugfs.c
> +++ b/drivers/scsi/lpfc/lpfc_debugfs.c
> @@ -31,6 +31,7 @@
> #include <linux/pci.h>
> #include <linux/spinlock.h>
> #include <linux/ctype.h>
> +#include <linux/vmalloc.h>
>
> #include <scsi/scsi.h>
> #include <scsi/scsi_device.h>

Reviewed-by: Ewan D. Milne <[email protected]>

2019-10-29 07:24:39

by Martin K. Petersen

Subject: Re: [PATCH] lpfc: fix build error of lpfc_debugfs.c for vfree/vmalloc

James,

> lpfc_debufs.c was missing include of vmalloc.h when compiled on PPC.
>
> Add missing header.

Applied to 5.5/scsi-queue, thanks!

--
Martin K. Petersen Oracle Linux Engineering