2019-10-26 02:24:55

by Mao Wenan

Subject: [PATCH -next] net: dsa: LAN9303: select REGMAP when LAN9303 enable

When NET_DSA_SMSC_LAN9303=y and NET_DSA_SMSC_LAN9303_MDIO=y,
below errors can be seen:
drivers/net/dsa/lan9303_mdio.c:87:23: error: REGMAP_ENDIAN_LITTLE
undeclared here (not in a function)
.reg_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/net/dsa/lan9303_mdio.c:93:3: error: const struct regmap_config
has no member named reg_read
.reg_read = lan9303_mdio_read,

It should select REGMAP in config NET_DSA_SMSC_LAN9303.

Fixes: dc7005831523 ("net: dsa: LAN9303: add MDIO managed mode support")
Signed-off-by: Mao Wenan <[email protected]>
---
drivers/net/dsa/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index f6232ce..685e12b 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -77,6 +77,7 @@ config NET_DSA_REALTEK_SMI
config NET_DSA_SMSC_LAN9303
tristate
select NET_DSA_TAG_LAN9303
+ select REGMAP
---help---
This enables support for the SMSC/Microchip LAN9303 3 port ethernet
switch chips.
--
2.7.4

2019-10-29 23:19:27

by David Miller

Subject: Re: [PATCH -next] net: dsa: LAN9303: select REGMAP when LAN9303 enable

From: Mao Wenan <[email protected]>
Date: Sat, 26 Oct 2019 10:21:39 +0800

> When NET_DSA_SMSC_LAN9303=y and NET_DSA_SMSC_LAN9303_MDIO=y,
> below errors can be seen:
> drivers/net/dsa/lan9303_mdio.c:87:23: error: REGMAP_ENDIAN_LITTLE
> undeclared here (not in a function)
> .reg_format_endian = REGMAP_ENDIAN_LITTLE,
> drivers/net/dsa/lan9303_mdio.c:93:3: error: const struct regmap_config
> has no member named reg_read
> .reg_read = lan9303_mdio_read,
>
> It should select REGMAP in config NET_DSA_SMSC_LAN9303.
>
> Fixes: dc7005831523 ("net: dsa: LAN9303: add MDIO managed mode support")
> Signed-off-by: Mao Wenan <[email protected]>

Applied.