Use devm_platform_ioremap_resource helper which wraps
platform_get_resource() and devm_ioremap_resource() together. Issue
found by coccicheck.
Signed-off-by: Cristiane Naves <[email protected]>
---
drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fieldbus/anybuss/arcx-anybus.c b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
index 2ecffa4..5b8d0ba 100644
--- a/drivers/staging/fieldbus/anybuss/arcx-anybus.c
+++ b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
@@ -127,12 +127,10 @@ static const struct regmap_config arcx_regmap_cfg = {
static struct regmap *create_parallel_regmap(struct platform_device *pdev,
int idx)
{
- struct resource *res;
void __iomem *base;
struct device *dev = &pdev->dev;
- res = platform_get_resource(pdev, IORESOURCE_MEM, idx + 1);
- base = devm_ioremap_resource(dev, res);
+ base = devm_platform_ioremap_resource(pdev, idx + 1);
if (IS_ERR(base))
return ERR_CAST(base);
return devm_regmap_init_mmio(dev, base, &arcx_regmap_cfg);
@@ -230,7 +228,6 @@ static int controller_probe(struct platform_device *pdev)
struct regulator_config config = { };
struct regulator_dev *regulator;
int err, id;
- struct resource *res;
struct anybuss_host *host;
u8 status1, cap;
@@ -244,8 +241,7 @@ static int controller_probe(struct platform_device *pdev)
return PTR_ERR(cd->reset_gpiod);
/* CPLD control memory, sits at index 0 */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- cd->cpld_base = devm_ioremap_resource(dev, res);
+ cd->cpld_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(cd->cpld_base)) {
dev_err(dev,
"failed to map cpld base address\n");
--
2.7.4
On Sat, Oct 26, 2019 at 7:52 PM Cristiane Naves
<[email protected]> wrote:
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together. Issue
> found by coccicheck.
>
> Signed-off-by: Cristiane Naves <[email protected]>
This is a duplicate of:
https://www.spinics.net/lists/linux-driver-devel/msg129526.html
and
https://lore.kernel.org/patchwork/patch/1140024/
When you find an issue, please search the mailing list(s) first to check
if it is being discussed already.
On Mon, Oct 28, 2019 at 2:28 PM Cristiane Naves
<[email protected]> wrote:
>
> Sorry, I was searching for the issue only on outreachy mailing list and
> had found nothing about it.
> I didn't know about these other mailing lists.
> Thanks for the feedback!
No need to apologize, most of us are always learning !
Next time, you can get the mailing lists to check by running the
get_maintainer.pl script on the file(s) you are going to modify:
$ ./scripts/get_maintainer.pl drivers/staging/fieldbus/anybuss/arcx-anybus.c
<snip>
[email protected] (open list:STAGING SUBSYSTEM)
[email protected] (open list)
On Sat, Oct 26, 2019 at 7:52 PM Cristiane Naves
<[email protected]> wrote:
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together. Issue
> found by coccicheck.
>
> Signed-off-by: Cristiane Naves <[email protected]>
> ---
> drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
Reviewed-by: Sven Van Asbroeck <[email protected]>
Tested-by: Sven Van Asbroeck <[email protected]>
Greg has already queued this patch, but the link embedded in
his commit message should point people here.