2019-10-25 21:25:02

by Rob Clark

Subject: [PATCH] arm64: dts: qcom: sdm845-cheza: delete zap-shader

From: Rob Clark <[email protected]>

This is unused on cheza. Delete the node to get ride of the reserved-
memory section, and to avoid the driver from attempting to load a zap
shader that doesn't exist every time it powers up the GPU.

(This also avoids a massive amount of dmesg spam about missing zap fw.)

Signed-off-by: Rob Clark <[email protected]>
Cc: Douglas Anderson <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 34881c0113cb..99a28d64ee62 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -165,6 +165,8 @@
/delete-node/ &venus_mem;
/delete-node/ &cdsp_mem;
/delete-node/ &cdsp_pas;
+/delete-node/ &zap_shader;
+/delete-node/ &gpu_mem;

/* Increase the size from 120 MB to 128 MB */
&mpss_region {
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index f406a4340b05..2287354fef86 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2824,7 +2824,7 @@

qcom,gmu = <&gmu>;

- zap-shader {
+ zap_shader: zap-shader {
memory-region = <&gpu_mem>;
};

--
2.21.0

2019-10-25 21:30:08

by Doug Anderson

Subject: Re: [PATCH] arm64: dts: qcom: sdm845-cheza: delete zap-shader

Hi,

On Fri, Oct 25, 2019 at 2:23 PM Rob Clark <[email protected]> wrote:
>
> From: Rob Clark <[email protected]>
>
> This is unused on cheza. Delete the node to get ride of the reserved-
> memory section, and to avoid the driver from attempting to load a zap
> shader that doesn't exist every time it powers up the GPU.
>
> (This also avoids a massive amount of dmesg spam about missing zap fw.)

optional nit: maybe when this is applied Bjorn / Andy can put in the
actual error message to make this easier to find if anyone is seeing
this problem. Specifically:

msm ae00000.mdss: [drm:adreno_request_fw] *ERROR* failed to load
qcom/a630_zap.mdt: -2
adreno 5000000.gpu: [drm:adreno_zap_shader_load] *ERROR* Unable to
load a630_zap.mdt


> Signed-off-by: Rob Clark <[email protected]>
> Cc: Douglas Anderson <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)

I probably would have put it in two patches (one for sdm845.dtsi and
one for cheza) but that's more because I'm obsessive-compulsive than
for any real reason. ;-) In any case:

Fixes: 3fdeaee951aa ("arm64: dts: sdm845: Add zap shader region for GPU")
Reviewed-by: Douglas Anderson <[email protected]>
Tested-by: Douglas Anderson <[email protected]>

-Doug

2019-10-27 05:41:54

by Andy Gross

Subject: Re: [PATCH] arm64: dts: qcom: sdm845-cheza: delete zap-shader

On Fri, Oct 25, 2019 at 02:28:22PM -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, Oct 25, 2019 at 2:23 PM Rob Clark <[email protected]> wrote:
> >
> > From: Rob Clark <[email protected]>
> >
> > This is unused on cheza. Delete the node to get ride of the reserved-
> > memory section, and to avoid the driver from attempting to load a zap
> > shader that doesn't exist every time it powers up the GPU.
> >
> > (This also avoids a massive amount of dmesg spam about missing zap fw.)
>
> optional nit: maybe when this is applied Bjorn / Andy can put in the
> actual error message to make this easier to find if anyone is seeing
> this problem. Specifically:
>
> msm ae00000.mdss: [drm:adreno_request_fw] *ERROR* failed to load
> qcom/a630_zap.mdt: -2
> adreno 5000000.gpu: [drm:adreno_zap_shader_load] *ERROR* Unable to
> load a630_zap.mdt
>
>
> > Signed-off-by: Rob Clark <[email protected]>
> > Cc: Douglas Anderson <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> > 2 files changed, 3 insertions(+), 1 deletion(-)
>
> I probably would have put it in two patches (one for sdm845.dtsi and
> one for cheza) but that's more because I'm obsessive-compulsive than
> for any real reason. ;-) In any case:
>
> Fixes: 3fdeaee951aa ("arm64: dts: sdm845: Add zap shader region for GPU")
> Reviewed-by: Douglas Anderson <[email protected]>
> Tested-by: Douglas Anderson <[email protected]>

Applied this patch and added in the dmesg error messages.

Andy