2019-10-28 20:02:45

by Yue Haibing

Subject: [PATCH net-next] ionic: Remove set but not used variable 'sg_desc'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_empty':
drivers/net/ethernet/pensando/ionic/ionic_txrx.c:405:28: warning:
variable 'sg_desc' set but not used [-Wunused-but-set-variable]

It is never used, so can be removed.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
index 0aeac3157160..97e79949b359 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
@@ -402,7 +402,6 @@ static void ionic_rx_fill_cb(void *arg)

void ionic_rx_empty(struct ionic_queue *q)
{
- struct ionic_rxq_sg_desc *sg_desc;
struct ionic_desc_info *cur;
struct ionic_rxq_desc *desc;
unsigned int i;
@@ -412,7 +411,6 @@ void ionic_rx_empty(struct ionic_queue *q)
desc->addr = 0;
desc->len = 0;

- sg_desc = cur->sg_desc;
for (i = 0; i < cur->npages; i++) {
if (likely(cur->pages[i].page)) {
ionic_rx_page_free(q, cur->pages[i].page,

2019-10-28 21:18:45

by Shannon Nelson

Subject: Re: [PATCH net-next] ionic: Remove set but not used variable 'sg_desc'

On 10/28/19 5:01 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_empty':
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c:405:28: warning:
> variable 'sg_desc' set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Shannon Nelson <[email protected]>


> ---
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> index 0aeac3157160..97e79949b359 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> @@ -402,7 +402,6 @@ static void ionic_rx_fill_cb(void *arg)
>
> void ionic_rx_empty(struct ionic_queue *q)
> {
> - struct ionic_rxq_sg_desc *sg_desc;
> struct ionic_desc_info *cur;
> struct ionic_rxq_desc *desc;
> unsigned int i;
> @@ -412,7 +411,6 @@ void ionic_rx_empty(struct ionic_queue *q)
> desc->addr = 0;
> desc->len = 0;
>
> - sg_desc = cur->sg_desc;
> for (i = 0; i < cur->npages; i++) {
> if (likely(cur->pages[i].page)) {
> ionic_rx_page_free(q, cur->pages[i].page,
>
>
>

2019-10-29 23:47:41

by David Miller

Subject: Re: [PATCH net-next] ionic: Remove set but not used variable 'sg_desc'

From: YueHaibing <[email protected]>
Date: Mon, 28 Oct 2019 12:01:21 +0000

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_empty':
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c:405:28: warning:
> variable 'sg_desc' set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <[email protected]>

Applied, thanks.