2019-10-28 22:02:01

by Saurav Girepunje

Subject: [PATCH] net: wireless: rtlwifi: rtl8192c:Drop condition with no effect

As the "else if" and "else" branch body are identical the condition
has no effect. So drop the "else if" condition.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
index f2908ee5f860..4bef237f488d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c
@@ -1649,8 +1649,6 @@ static void rtl92c_bt_ant_isolation(struct ieee80211_hw *hw, u8 tmp1byte)
(rtlpriv->btcoexist.bt_rssi_state &
BT_RSSI_STATE_SPECIAL_LOW)) {
rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
- } else if (rtlpriv->btcoexist.bt_service == BT_PAN) {
- rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, tmp1byte);
} else {
rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, tmp1byte);
}
--
2.20.1

2019-10-29 15:08:53

by Kalle Valo

Subject: Re: [PATCH] net: wireless: rtlwifi: rtl8192c:Drop condition with no effect

Saurav Girepunje <[email protected]> writes:

> As the "else if" and "else" branch body are identical the condition
> has no effect. So drop the "else if" condition.
>
> Signed-off-by: Saurav Girepunje <[email protected]>

Thanks, I see these patches in patchwork now.

But then you submit a new version of a patch, please mark it as "[PATCH v2]":

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing

This is for future submissions, no need to resend because of this.

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches