2019-10-28 22:02:40

by Saurav Girepunje

Subject: [PATCH] b43: Fix use true/false for bool type

use true/false on bool type variable assignment.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/net/wireless/broadcom/b43/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index b85603e91c7a..39da1a4c30ac 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
else
err = b43_dma_tx(dev, skb);
if (err == -ENOSPC) {
- wl->tx_queue_stopped[queue_num] = 1;
+ wl->tx_queue_stopped[queue_num] = true;
ieee80211_stop_queue(wl->hw, queue_num);
skb_queue_head(&wl->tx_queue[queue_num], skb);
break;
@@ -3611,7 +3611,7 @@ static void b43_tx_work(struct work_struct *work)
}

if (!err)
- wl->tx_queue_stopped[queue_num] = 0;
+ wl->tx_queue_stopped[queue_num] = false;
}

#if B43_DEBUG
@@ -5603,7 +5603,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev)
/* Initialize queues and flags. */
for (queue_num = 0; queue_num < B43_QOS_QUEUE_NUM; queue_num++) {
skb_queue_head_init(&wl->tx_queue[queue_num]);
- wl->tx_queue_stopped[queue_num] = 0;
+ wl->tx_queue_stopped[queue_num] = false;
}

snprintf(chip_name, ARRAY_SIZE(chip_name),
--
2.20.1

2019-10-29 08:31:44

by Joe Perches

Subject: Re: [PATCH] b43: Fix use true/false for bool type

On Tue, 2019-10-29 at 09:24 +0100, Simon Horman wrote:
> I wonder why bools rather than a bitmask was chosen
> for this field, it seems rather space intensive in its current form.

4 bools is not intensive.

> > diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
[]
> > @@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
[]
> > - wl->tx_queue_stopped[queue_num] = 1;
> > + wl->tx_queue_stopped[queue_num] = true;

2019-10-31 08:09:29

by Kalle Valo

Subject: Re: [PATCH] b43: main: Fix use true/false for bool type

Saurav Girepunje <[email protected]> wrote:

> use true/false on bool type variable assignment.
>
> Signed-off-by: Saurav Girepunje <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

6db774c17250 b43: main: Fix use true/false for bool type

--
https://patchwork.kernel.org/patch/11216303/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches