2019-10-28 22:08:27

by Saurav Girepunje

Subject: [PATCH] scsi: csiostor: Return value not required for csio_dfs_destroy.

Only csio_hw_free() calling csio_dfs_destroy() and it is not
checking return value. So remove the return from csio_dfs_destroy().

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/scsi/csiostor/csio_init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/csiostor/csio_init.c b/drivers/scsi/csiostor/csio_init.c
index a6dd704d7f2d..28b77fa8b015 100644
--- a/drivers/scsi/csiostor/csio_init.c
+++ b/drivers/scsi/csiostor/csio_init.c
@@ -154,13 +154,11 @@ csio_dfs_create(struct csio_hw *hw)
/*
* csio_dfs_destroy - Destroys per-hw debugfs.
*/
-static int
+static void
csio_dfs_destroy(struct csio_hw *hw)
{
if (hw->debugfs_root)
debugfs_remove_recursive(hw->debugfs_root);
-
- return 0;
}

/*
--
2.20.1

2019-11-02 00:24:01

by Martin K. Petersen

Subject: Re: [PATCH] scsi: csiostor: Return value not required for csio_dfs_destroy.

Saurav,

> Only csio_hw_free() calling csio_dfs_destroy() and it is not
> checking return value. So remove the return from csio_dfs_destroy().

Applied to 5.5/scsi-queue, thanks.

--
Martin K. Petersen Oracle Linux Engineering