2019-10-25 20:47:18

by Colin King

Subject: [PATCH] net: fec: remove redundant assignment to pointer bdp

From: Colin Ian King <[email protected]>

The pointer bdp is being assigned with a value that is never
read, so the assignment is redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/freescale/fec_main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index d4d4c72adf49..608196bdd892 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2706,7 +2706,6 @@ static void fec_enet_free_buffers(struct net_device *ndev)

for (q = 0; q < fep->num_tx_queues; q++) {
txq = fep->tx_queue[q];
- bdp = txq->bd.base;
for (i = 0; i < txq->bd.ring_size; i++) {
kfree(txq->tx_bounce[i]);
txq->tx_bounce[i] = NULL;
--
2.20.1

2019-10-26 04:57:05

by Andy Duan

Subject: RE: [EXT] [PATCH] net: fec: remove redundant assignment to pointer bdp

From: Colin King <[email protected]> Sent: Saturday, October 26, 2019 1:23 AM
> The pointer bdp is being assigned with a value that is never read, so the
> assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
Thanks.

Acked-by: Fugang Duan <[email protected]>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d4d4c72adf49..608196bdd892 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2706,7 +2706,6 @@ static void fec_enet_free_buffers(struct
> net_device *ndev)
>
> for (q = 0; q < fep->num_tx_queues; q++) {
> txq = fep->tx_queue[q];
> - bdp = txq->bd.base;
> for (i = 0; i < txq->bd.ring_size; i++) {
> kfree(txq->tx_bounce[i]);
> txq->tx_bounce[i] = NULL;
> --
> 2.20.1

2019-10-29 22:10:09

by David Miller

Subject: Re: [PATCH] net: fec: remove redundant assignment to pointer bdp

From: Colin King <[email protected]>
Date: Fri, 25 Oct 2019 18:22:55 +0100

> From: Colin Ian King <[email protected]>
>
> The pointer bdp is being assigned with a value that is never
> read, so the assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Applied to net-next, thanks.