2019-10-29 17:10:08

by Saurav Girepunje

Subject: [PATCH v1] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup

Remove multiple kfree statement from phram_setup() in phram.c

Signed-off-by: Saurav Girepunje <[email protected]>
---

Change in v1:

- Add change suggested by Miquel Raynal <[email protected]>
"The goto statement should not describe from where it is called but the
action it is supposed to take. 'goto free_nam;' would be better."

drivers/mtd/devices/phram.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index c467286ca007..38f95a1517ac 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -243,22 +243,22 @@ static int phram_setup(const char *val)

ret = parse_num64(&start, token[1]);
if (ret) {
- kfree(name);
parse_err("illegal start address\n");
+ goto free_nam;
}

ret = parse_num64(&len, token[2]);
if (ret) {
- kfree(name);
parse_err("illegal device length\n");
+ goto free_nam;
}

ret = register_device(name, start, len);
if (!ret)
pr_info("%s device: %#llx at %#llx\n", name, len, start);
- else
- kfree(name);

+free_nam:
+ kfree(name);
return ret;
}

--
2.20.1

2019-10-30 08:21:54

by Miquel Raynal

Subject: Re: [PATCH v1] mtd: devices: phram.c: Fix multiple kfree statement from phram_setup

Saurav,

Saurav Girepunje <[email protected]> wrote on Tue, 29 Oct 2019
22:38:49 +0530:

Are you a robot?

> Remove multiple kfree statement from phram_setup() in phram.c

This does not describe what you are doing, you don't remove them you
factorize them. And honestly I am not convinced this change is useful
in old code.

>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
>
> Change in v1:

Your first version is v1, how can you be at v1? It is almost v3 already!

>
> - Add change suggested by Miquel Raynal <[email protected]>
> "The goto statement should not describe from where it is called but the
> action it is supposed to take. 'goto free_nam;' would be better."

This is a copy/paste of what I have said. What I want you to write is:

"
- Rename the goto statement to describe bla bla bla.
- Fix the typo in the goto label.
"

>
> drivers/mtd/devices/phram.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
> index c467286ca007..38f95a1517ac 100644
> --- a/drivers/mtd/devices/phram.c
> +++ b/drivers/mtd/devices/phram.c
> @@ -243,22 +243,22 @@ static int phram_setup(const char *val)
>
> ret = parse_num64(&start, token[1]);
> if (ret) {
> - kfree(name);
> parse_err("illegal start address\n");
> + goto free_nam;

Come one...


Thanks,
Miquèl