2019-10-29 20:12:16

by Jim Cromie

[permalink] [raw]
Subject: [PATCH 02/16] dyndbg: drop overwrought comment on ddebug_proc_open

commit 4bad78c55002 ("lib/dynamic_debug.c: use seq_open_private() instead of seq_open()")'

The commit simplified ddebug_proc_open, replacing boilerplate with a
function call, and obsoleting the florid comment about that code. btw,
git blame shows me as comment author.

Signed-off-by: Jim Cromie <[email protected]>
---
lib/dynamic_debug.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index ba35199edd9c..8fb140a55ad3 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -840,13 +840,6 @@ static const struct seq_operations ddebug_proc_seqops = {
.stop = ddebug_proc_stop
};

-/*
- * File_ops->open method for <debugfs>/dynamic_debug/control. Does
- * the seq_file setup dance, and also creates an iterator to walk the
- * _ddebugs. Note that we create a seq_file always, even for O_WRONLY
- * files where it's not needed, as doing so simplifies the ->release
- * method.
- */
static int ddebug_proc_open(struct inode *inode, struct file *file)
{
vpr_info("called\n");
--
2.21.0