2019-10-30 19:14:33

by Gabriela Bittencourt

Subject: [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h

Cleans up checks of "Avoid CamelCase" in file sd.h

Signed-off-by: Gabriela Bittencourt <[email protected]>
---
drivers/staging/rts5208/sd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h
index dc9e8cad7a74..f4ff62653b56 100644
--- a/drivers/staging/rts5208/sd.h
+++ b/drivers/staging/rts5208/sd.h
@@ -232,7 +232,7 @@
#define DCM_LOW_FREQUENCY_MODE 0x01

#define DCM_HIGH_FREQUENCY_MODE_SET 0x0C
-#define DCM_Low_FREQUENCY_MODE_SET 0x00
+#define DCM_LOW_FREQUENCY_MODE_SET 0x00

#define MULTIPLY_BY_1 0x00
#define MULTIPLY_BY_2 0x01
--
2.20.1

2019-10-31 06:37:52

by Julia Lawall

Subject: Re: [Outreachy kernel] [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h

On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:

> Cleans up checks of "Avoid CamelCase" in file sd.h
>
> Signed-off-by: Gabriela Bittencourt <[email protected]>
> ---
> drivers/staging/rts5208/sd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/sd.h b/drivers/staging/rts5208/sd.h
> index dc9e8cad7a74..f4ff62653b56 100644
> --- a/drivers/staging/rts5208/sd.h
> +++ b/drivers/staging/rts5208/sd.h
> @@ -232,7 +232,7 @@
> #define DCM_LOW_FREQUENCY_MODE 0x01
>
> #define DCM_HIGH_FREQUENCY_MODE_SET 0x0C
> -#define DCM_Low_FREQUENCY_MODE_SET 0x00
> +#define DCM_LOW_FREQUENCY_MODE_SET 0x00

So this is never used in the kernel? In that case, maybe it would still
be useful to keep it, because it somehow documents the device. But the
log message should say that this is the case.

julia

>
> #define MULTIPLY_BY_1 0x00
> #define MULTIPLY_BY_2 0x01
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030190514.10011-4-gabrielabittencourt00%40gmail.com.
>