2019-11-01 16:01:07

by Julien Grall

Subject: [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]

From: Julien Grall <[email protected]>

Commit "docs/arm64: cpu-feature-registers: Documents missing visible
fields" added bitfiels following the convention [s, e]. However, the
documentation is following [s, e] and so does the Arm ARM.

Rewrite the bitfields to match the format [e, s].

Signed-off-by: Julien Grall <[email protected]>

---

This is based on the branch for-next/elf-hwcap-docs from the tree
arm64/linux.git.
---
Documentation/arm64/cpu-feature-registers.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/arm64/cpu-feature-registers.rst b/Documentation/arm64/cpu-feature-registers.rst
index ffcf4e2c71ef..7c40e4581bae 100644
--- a/Documentation/arm64/cpu-feature-registers.rst
+++ b/Documentation/arm64/cpu-feature-registers.rst
@@ -193,9 +193,9 @@ infrastructure:
+------------------------------+---------+---------+
| Name | bits | visible |
+------------------------------+---------+---------+
- | SB | [36-39] | y |
+ | SB | [39-36] | y |
+------------------------------+---------+---------+
- | FRINTTS | [32-35] | y |
+ | FRINTTS | [35-32] | y |
+------------------------------+---------+---------+
| GPI | [31-28] | y |
+------------------------------+---------+---------+
--
2.17.1

2019-11-01 16:06:36

by Will Deacon

Subject: Re: [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]

On Fri, Nov 01, 2019 at 03:20:22PM +0000, Julien Grall wrote:
> From: Julien Grall <[email protected]>
>
> Commit "docs/arm64: cpu-feature-registers: Documents missing visible
> fields" added bitfiels following the convention [s, e]. However, the

typo: bitfiels

> documentation is following [s, e] and so does the Arm ARM.

This should be [e, s], although I think you can spell it out as "end" and
"start" so people know what this is doing.

>
> Rewrite the bitfields to match the format [e, s].
>
> Signed-off-by: Julien Grall <[email protected]>
>
> ---
>
> This is based on the branch for-next/elf-hwcap-docs from the tree
> arm64/linux.git.
> ---
> Documentation/arm64/cpu-feature-registers.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/arm64/cpu-feature-registers.rst b/Documentation/arm64/cpu-feature-registers.rst
> index ffcf4e2c71ef..7c40e4581bae 100644
> --- a/Documentation/arm64/cpu-feature-registers.rst
> +++ b/Documentation/arm64/cpu-feature-registers.rst
> @@ -193,9 +193,9 @@ infrastructure:
> +------------------------------+---------+---------+
> | Name | bits | visible |
> +------------------------------+---------+---------+
> - | SB | [36-39] | y |
> + | SB | [39-36] | y |
> +------------------------------+---------+---------+
> - | FRINTTS | [32-35] | y |
> + | FRINTTS | [35-32] | y |
> +------------------------------+---------+---------+
> | GPI | [31-28] | y |
> +------------------------------+---------+---------+

diff looks fine.

Will

2019-11-01 17:11:54

by Catalin Marinas

Subject: Re: [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]

On Fri, Nov 01, 2019 at 03:20:22PM +0000, Julien Grall wrote:
> From: Julien Grall <[email protected]>
>
> Commit "docs/arm64: cpu-feature-registers: Documents missing visible
> fields" added bitfiels following the convention [s, e]. However, the
> documentation is following [s, e] and so does the Arm ARM.
>
> Rewrite the bitfields to match the format [e, s].
>
> Signed-off-by: Julien Grall <[email protected]>

Applied. Thanks.

--
Catalin

2019-11-01 17:14:46

by Catalin Marinas

Subject: Re: [PATCH] docs/arm64: cpu-feature-registers: Rewrite bitfields that don't follow [e, s]

On Fri, Nov 01, 2019 at 03:38:04PM +0000, Will Deacon wrote:
> On Fri, Nov 01, 2019 at 03:20:22PM +0000, Julien Grall wrote:
> > From: Julien Grall <[email protected]>
> >
> > Commit "docs/arm64: cpu-feature-registers: Documents missing visible
> > fields" added bitfiels following the convention [s, e]. However, the
>
> typo: bitfiels
>
> > documentation is following [s, e] and so does the Arm ARM.
>
> This should be [e, s], although I think you can spell it out as "end" and
> "start" so people know what this is doing.

Thanks. I'll make the changes locally.

--
Catalin