2019-11-04 15:02:11

by Chuhong Yuan

[permalink] [raw]
Subject: [PATCH] i2c: hix5hd2: add missed clk_disable_unprepare in remove

The driver forgets to disable and unprepare clk when remove.
Add a call to clk_disable_unprepare to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/i2c/busses/i2c-hix5hd2.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-hix5hd2.c b/drivers/i2c/busses/i2c-hix5hd2.c
index 8497c7a95dd4..224f830f77f9 100644
--- a/drivers/i2c/busses/i2c-hix5hd2.c
+++ b/drivers/i2c/busses/i2c-hix5hd2.c
@@ -477,6 +477,7 @@ static int hix5hd2_i2c_remove(struct platform_device *pdev)
i2c_del_adapter(&priv->adap);
pm_runtime_disable(priv->dev);
pm_runtime_set_suspended(priv->dev);
+ clk_disable_unprepare(priv->clk);

return 0;
}
--
2.23.0


2020-03-22 16:15:30

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: hix5hd2: add missed clk_disable_unprepare in remove

On Mon, Nov 04, 2019 at 11:00:48PM +0800, Chuhong Yuan wrote:
> The driver forgets to disable and unprepare clk when remove.
> Add a call to clk_disable_unprepare to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>

Applied to for-current, thanks!


Attachments:
(No filename) (272.00 B)
signature.asc (849.00 B)
Download all attachments