2019-10-30 20:26:01

by Song Liu

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

I was trying to find the mm tree in MAINTAINERS by searching "Morton".
Unfortunately, I didn't find one. And I didn't even locate the MEMORY
MANAGEMENT section quickly, because Andrew's name was not listed there.

Thanks to Johannes who helped me find the mm tree.

Let save other's time searching around by adding:

M: Andrew Morton <[email protected]>
T: git git://github.com/hnaz/linux-mm.git

Cc: Johannes Weiner <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Song Liu <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a62ed61e6613..adafbe811e58 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10621,8 +10621,10 @@ F: mm/memblock.c
F: Documentation/core-api/boot-time-mm.rst

MEMORY MANAGEMENT
+M: Andrew Morton <[email protected]>
L: [email protected]
W: http://www.linux-mm.org
+T: git git://github.com/hnaz/linux-mm.git
S: Maintained
F: include/linux/mm.h
F: include/linux/gfp.h
--
2.17.1


2019-10-31 01:23:44

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

On Wed, 30 Oct 2019 13:22:17 -0700 Song Liu <[email protected]> wrote:

> I was trying to find the mm tree in MAINTAINERS by searching "Morton".
> Unfortunately, I didn't find one. And I didn't even locate the MEMORY
> MANAGEMENT section quickly, because Andrew's name was not listed there.
>
> Thanks to Johannes who helped me find the mm tree.

Oh all right ;)

If I listed everything I "maintain" in MAINTAINERS, I'd double the size
of the dang thing.

q:/usr/src/25> grep "^#NEXT_PATCHES_START" series | wc -l
364

(Those are the identifiable "trees" which I do (or did) "maintain").

But mm/ is special.

> Let save other's time searching around by adding:
>
> M: Andrew Morton <[email protected]>
> T: git git://github.com/hnaz/linux-mm.git

Also:

--- a/MAINTAINERS~maintainers-update-information-for-memory-management-fix
+++ a/MAINTAINERS
@@ -10523,6 +10523,8 @@ M: Andrew Morton <akpm@linux-foundation.
L: [email protected]
W: http://www.linux-mm.org
T: git git://github.com/hnaz/linux-mm.git
+T: quilt https://ozlabs.org/~akpm/mmotm/
+T: quilt https://ozlabs.org/~akpm/mmots/
S: Maintained
F: include/linux/mm.h
F: include/linux/gfp.h
_

2019-11-04 14:54:28

by Vlastimil Babka

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

On 10/30/19 9:22 PM, Song Liu wrote:
> I was trying to find the mm tree in MAINTAINERS by searching "Morton".
> Unfortunately, I didn't find one. And I didn't even locate the MEMORY
> MANAGEMENT section quickly, because Andrew's name was not listed there.
>
> Thanks to Johannes who helped me find the mm tree.
>
> Let save other's time searching around by adding:
>
> M: Andrew Morton <[email protected]>
> T: git git://github.com/hnaz/linux-mm.git

Not sure about the git part. It's not a real development tree, but a
secondary "mirror" of the quilt tree, with unstable commit ID's. Could
it be somehow indicated? Also right now it seems there's just mainline
master stuck at 5.4-rc5 and nothing else?

(And obviously, could we finally get a real git? :)

> Cc: Johannes Weiner <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Signed-off-by: Song Liu <[email protected]>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a62ed61e6613..adafbe811e58 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10621,8 +10621,10 @@ F: mm/memblock.c
> F: Documentation/core-api/boot-time-mm.rst
>
> MEMORY MANAGEMENT
> +M: Andrew Morton <[email protected]>
> L: [email protected]
> W: http://www.linux-mm.org
> +T: git git://github.com/hnaz/linux-mm.git
> S: Maintained
> F: include/linux/mm.h
> F: include/linux/gfp.h
>

2019-11-04 15:50:56

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

On Mon, Nov 04, 2019 at 03:53:18PM +0100, Vlastimil Babka wrote:
> On 10/30/19 9:22 PM, Song Liu wrote:
> > I was trying to find the mm tree in MAINTAINERS by searching "Morton".
> > Unfortunately, I didn't find one. And I didn't even locate the MEMORY
> > MANAGEMENT section quickly, because Andrew's name was not listed there.
> >
> > Thanks to Johannes who helped me find the mm tree.
> >
> > Let save other's time searching around by adding:
> >
> > M: Andrew Morton <[email protected]>
> > T: git git://github.com/hnaz/linux-mm.git
>
> Not sure about the git part. It's not a real development tree, but a
> secondary "mirror" of the quilt tree, with unstable commit ID's. Could
> it be somehow indicated? Also right now it seems there's just mainline
> master stuck at 5.4-rc5 and nothing else?

I think at the least we should put the quilt trees before the git
tree, since that's the primary source of truth.

Not sure how to annotate the git tree, though, it looks like people
were trying to keep the format machine-readable:

T: *SCM* tree type and location.
Type is one of: git, hg, quilt, stgit, topgit

Re: master branch, it looks like git quiltimport broke :( I'll
investigate.

2019-11-04 16:00:11

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

On Mon, Nov 04, 2019 at 10:47:23AM -0500, Johannes Weiner wrote:
> On Mon, Nov 04, 2019 at 03:53:18PM +0100, Vlastimil Babka wrote:
> > Also right now it seems there's just mainline master stuck at
> > 5.4-rc5 and nothing else?
>
> Re: master branch, it looks like git quiltimport broke :( I'll
> investigate.

git quiltimport was choking up on \r\n newlines in the series
file. Not sure if something changed on my end or on Andrew's.

Anyway, I fixed it with dos2unix. The tree is uptodate again.

Thanks for pointing it out, Vlastimil.

2019-11-05 09:46:42

by Michal Hocko

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

On Mon 04-11-19 15:53:18, Vlastimil Babka wrote:
[...]
> (And obviously, could we finally get a real git? :)

I would love to see that happen! While I do appreciate existance of
Johannes' mirror that is not something that is suitable for a long term
development IMHO because the tree rebases constantly.

And while we are talking about a better information on the MM
maintainership, should we also be explicit about maintainers of MM parts
which have a primary go to person? At least compaction, allocator, OOM,
memory hotplug, THP, shmem, memory hwpoisoning, early allocators come to
mind.
--
Michal Hocko
SUSE Labs

2019-11-05 10:17:56

by David Hildenbrand

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

On 05.11.19 10:45, Michal Hocko wrote:
> On Mon 04-11-19 15:53:18, Vlastimil Babka wrote:
> [...]
>> (And obviously, could we finally get a real git? :)
>
> I would love to see that happen! While I do appreciate existance of
> Johannes' mirror that is not something that is suitable for a long term
> development IMHO because the tree rebases constantly.
>
> And while we are talking about a better information on the MM
> maintainership, should we also be explicit about maintainers of MM parts
> which have a primary go to person? At least compaction, allocator, OOM,
> memory hotplug, THP, shmem, memory hwpoisoning, early allocators come to
> mind.

Yes please. This is valuable information.


--

Thanks,

David / dhildenb

2019-11-05 13:24:37

by Mike Rapoport

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update information for "MEMORY MANAGEMENT"

On Wed, Oct 30, 2019 at 06:21:04PM -0700, Andrew Morton wrote:
> On Wed, 30 Oct 2019 13:22:17 -0700 Song Liu <[email protected]> wrote:
>
> > I was trying to find the mm tree in MAINTAINERS by searching "Morton".
> > Unfortunately, I didn't find one. And I didn't even locate the MEMORY
> > MANAGEMENT section quickly, because Andrew's name was not listed there.
> >
> > Thanks to Johannes who helped me find the mm tree.
>
> Oh all right ;)
>
> If I listed everything I "maintain" in MAINTAINERS, I'd double the size
> of the dang thing.
>
> q:/usr/src/25> grep "^#NEXT_PATCHES_START" series | wc -l
> 364
>
> (Those are the identifiable "trees" which I do (or did) "maintain").
>
> But mm/ is special.
>
> > Let save other's time searching around by adding:
> >
> > M: Andrew Morton <[email protected]>
> > T: git git://github.com/hnaz/linux-mm.git
>
> Also:
>
> --- a/MAINTAINERS~maintainers-update-information-for-memory-management-fix
> +++ a/MAINTAINERS
> @@ -10523,6 +10523,8 @@ M: Andrew Morton <akpm@linux-foundation.
> L: [email protected]
> W: http://www.linux-mm.org
> T: git git://github.com/hnaz/linux-mm.git
> +T: quilt https://ozlabs.org/~akpm/mmotm/
> +T: quilt https://ozlabs.org/~akpm/mmots/
> S: Maintained
> F: include/linux/mm.h
> F: include/linux/gfp.h

The F: section here is also seems too sparse, at the very least we could
add include/linux/mm_types.h and include/linux/page*h:

diff --git a/MAINTAINERS b/MAINTAINERS
index c6c34d04ce95..5e4ed4bc2372 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10526,6 +10526,8 @@ F: include/linux/mm.h
F: include/linux/gfp.h
F: include/linux/mmzone.h
F: include/linux/memory_hotplug.h
+F: include/linux/mm_types.h
+F: include/linux/page*h
F: include/linux/vmalloc.h
F: mm/


> _
>
>

--
Sincerely yours,
Mike.