2019-11-04 08:21:51

by Peng Fan

Subject: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk

From: Peng Fan <[email protected]>

It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
without ipg clk. Actually there are ipg clks for other sai clks,
let's add IMX8MN_CLK_SAI7_IPG clk.

Signed-off-by: Peng Fan <[email protected]>
---
drivers/clk/imx/clk-imx8mn.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 838f6e2347f1..5e801892c631 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
+ clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);

clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);

--
2.16.4

2019-11-04 08:24:42

by Peng Fan

Subject: RE: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk

> Subject: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk

Missed to add, patch was made based on clk_hw API patch
https://patchwork.kernel.org/patch/11224941/

Thanks,
Peng.
>
> From: Peng Fan <[email protected]>
>
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks, let's add
> IMX8MN_CLK_SAI7_IPG clk.
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> drivers/clk/imx/clk-imx8mn.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct
> platform_device *pdev)
> clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk",
> "ipg_audio_root", base + 0x43b0, 0);
> clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk",
> "ipg_audio_root", base + 0x45f0, 0);
> clks[IMX8MN_CLK_SAI7_ROOT] =
> imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0,
> &share_count_sai7);
> + clks[IMX8MN_CLK_SAI7_IPG] =
> imx_clk_hw_gate2_shared2("sai7_ipg_clk",
> +"ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
>
> clks[IMX8MN_CLK_DRAM_ALT_ROOT] =
> imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
>
> --
> 2.16.4

2019-11-05 11:37:51

by Abel Vesa

Subject: Re: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk

On 19-11-04 08:19:33, Peng Fan wrote:
> From: Peng Fan <[email protected]>
>
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks,
> let's add IMX8MN_CLK_SAI7_IPG clk.
>
> Signed-off-by: Peng Fan <[email protected]>

Reviewed-by: Abel Vesa <[email protected]>

> ---
> drivers/clk/imx/clk-imx8mn.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
> clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
> clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
> clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
> + clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
>
> clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
>
> --
> 2.16.4
>