2019-10-29 19:24:00

by Masahiro Yamada

Subject: [PATCH 4/4] mospost: remove unneeded local variable in contains_namespace()

The local variable, ns_entry, is unneeded.

While I was here, I also cleaned up the comparison with NULL or 0.

Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/mod/modpost.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index f7425f5d4ab0..f70b924f379f 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name)
static bool contains_namespace(struct namespace_list *list,
const char *namespace)
{
- struct namespace_list *ns_entry;
-
- for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next)
- if (strcmp(ns_entry->namespace, namespace) == 0)
+ for (; list; list = list->next)
+ if (!strcmp(list->namespace, namespace))
return true;

return false;
--
2.17.1

2019-11-05 13:48:49

by Matthias Maennich

Subject: Re: [PATCH 4/4] mospost: remove unneeded local variable in contains_namespace()

Hi!

On Tue, Oct 29, 2019 at 09:38:09PM +0900, Masahiro Yamada wrote:
>The local variable, ns_entry, is unneeded.
>
>While I was here, I also cleaned up the comparison with NULL or 0.
>
>Signed-off-by: Masahiro Yamada <[email protected]>
>---

This was not directly sent to me, hence I missed it.
Nevertheless, please feel free to add

Reviewed-by: Matthias Maennich <[email protected]>

Cheers,
Matthias
>
> scripts/mod/modpost.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>index f7425f5d4ab0..f70b924f379f 100644
>--- a/scripts/mod/modpost.c
>+++ b/scripts/mod/modpost.c
>@@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name)
> static bool contains_namespace(struct namespace_list *list,
> const char *namespace)
> {
>- struct namespace_list *ns_entry;
>-
>- for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next)
>- if (strcmp(ns_entry->namespace, namespace) == 0)
>+ for (; list; list = list->next)
>+ if (!strcmp(list->namespace, namespace))
> return true;
>
> return false;
>--
>2.17.1
>

2019-11-06 15:41:18

by Masahiro Yamada

Subject: Re: [PATCH 4/4] mospost: remove unneeded local variable in contains_namespace()

On Tue, Oct 29, 2019 at 9:38 PM Masahiro Yamada
<[email protected]> wrote:
>
> The local variable, ns_entry, is unneeded.
>
> While I was here, I also cleaned up the comparison with NULL or 0.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

Fixed the typo in the subject ( mospost -> modpost )
and applied to linux-kbuild.


>
> scripts/mod/modpost.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index f7425f5d4ab0..f70b924f379f 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -239,10 +239,8 @@ static struct symbol *find_symbol(const char *name)
> static bool contains_namespace(struct namespace_list *list,
> const char *namespace)
> {
> - struct namespace_list *ns_entry;
> -
> - for (ns_entry = list; ns_entry != NULL; ns_entry = ns_entry->next)
> - if (strcmp(ns_entry->namespace, namespace) == 0)
> + for (; list; list = list->next)
> + if (!strcmp(list->namespace, namespace))
> return true;
>
> return false;
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada