Move from the deprecated i2c_new_probed_device() to the new
i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
Signed-off-by: Wolfram Sang <[email protected]>
---
Build tested only. RFC, please comment and/or ack, but don't apply yet.
drivers/media/pci/cx88/cx88-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx88/cx88-input.c b/drivers/media/pci/cx88/cx88-input.c
index 589f52d961eb..c7c2acd55266 100644
--- a/drivers/media/pci/cx88/cx88-input.c
+++ b/drivers/media/pci/cx88/cx88-input.c
@@ -613,7 +613,7 @@ void cx88_i2c_init_ir(struct cx88_core *core)
}
/*
- * We can't call i2c_new_probed_device() because it uses
+ * We can't call i2c_new_scanned_device() because it uses
* quick writes for probing and at least some RC receiver
* devices only reply to reads.
* Also, Hauppauge XVR needs to be specified, as address 0x71
--
2.20.1
On 11/6/19 10:50 AM, Wolfram Sang wrote:
> Move from the deprecated i2c_new_probed_device() to the new
> i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
This commit text is a bit out-of-sync with the actual patch.
This should be improved for the next version. Looks good otherwise.
Regards,
Hans
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
>
> Build tested only. RFC, please comment and/or ack, but don't apply yet.
>
> drivers/media/pci/cx88/cx88-input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/cx88/cx88-input.c b/drivers/media/pci/cx88/cx88-input.c
> index 589f52d961eb..c7c2acd55266 100644
> --- a/drivers/media/pci/cx88/cx88-input.c
> +++ b/drivers/media/pci/cx88/cx88-input.c
> @@ -613,7 +613,7 @@ void cx88_i2c_init_ir(struct cx88_core *core)
> }
>
> /*
> - * We can't call i2c_new_probed_device() because it uses
> + * We can't call i2c_new_scanned_device() because it uses
> * quick writes for probing and at least some RC receiver
> * devices only reply to reads.
> * Also, Hauppauge XVR needs to be specified, as address 0x71
>
On Wed, Nov 06, 2019 at 12:18:28PM +0100, Hans Verkuil wrote:
> On 11/6/19 10:50 AM, Wolfram Sang wrote:
> > Move from the deprecated i2c_new_probed_device() to the new
> > i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
>
> This commit text is a bit out-of-sync with the actual patch.
Ha, true :) Thanks for pointing out (and the other reviews, too, of
course!)