2019-11-07 17:45:55

by Robin H. Johnson

Subject: [PATCH] firmware: log names of loaded firmware

It's non-trivial to figure out names of firmware that was actually
loaded, add a print statement at the end of _request_firmware that logs
the name & result of each firmware.

This is esp. valuable early in boot, before logging of UEVENT is
available.

Signed-off-by: Robin H. Johnson <[email protected]>
---
drivers/base/firmware_loader/main.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index bf44c79beae9..f0362af16b66 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -791,6 +791,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
fw = NULL;
}

+ dev_info(device, "%s %s ret=%d\n", __func__, name, ret);
+
*firmware_p = fw;
return ret;
}
--
2.24.0

2019-11-13 00:59:07

by Luis Chamberlain

Subject: Re: [PATCH] firmware: log names of loaded firmware

On Thu, Nov 07, 2019 at 09:43:53AM -0800, Robin H. Johnson wrote:
> It's non-trivial to figure out names of firmware that was actually
> loaded, add a print statement at the end of _request_firmware that logs
> the name & result of each firmware.
>
> This is esp. valuable early in boot, before logging of UEVENT is
> available.
>
> Signed-off-by: Robin H. Johnson <[email protected]>
> ---
> drivers/base/firmware_loader/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
> index bf44c79beae9..f0362af16b66 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c
> @@ -791,6 +791,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
> fw = NULL;
> }
>
> + dev_info(device, "%s %s ret=%d\n", __func__, name, ret);
> +

Thanks for your patch!

Sorry but we don't want to always print this. We however can *debug*
a system with dev_dbg() but there is a patch which someone is working
on which will do this. I cc'd you on it.

Luis