2019-11-11 12:45:25

by Colin King

Subject: [PATCH][next] cxgb4: remove redundant assignment to hdr_len

From: Colin Ian King <[email protected]>

Variable hdr_len is being assigned a value that is never read.
The assignment is redundant and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c
index e346830ebca9..09059adc3067 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sge.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c
@@ -3810,7 +3810,6 @@ int cxgb4_ethofld_rx_handler(struct sge_rspq *q, const __be64 *rsp,
eosw_txq->state ==
CXGB4_EO_STATE_FLOWC_CLOSE_REPLY) &&
eosw_txq->cidx == eosw_txq->flowc_idx)) {
- hdr_len = skb->len;
flits = DIV_ROUND_UP(skb->len, 8);
if (eosw_txq->state ==
CXGB4_EO_STATE_FLOWC_OPEN_REPLY)
--
2.20.1

2019-11-12 06:06:47

by David Miller

Subject: Re: [PATCH][next] cxgb4: remove redundant assignment to hdr_len

From: Colin King <[email protected]>
Date: Mon, 11 Nov 2019 12:44:13 +0000

> From: Colin Ian King <[email protected]>
>
> Variable hdr_len is being assigned a value that is never read.
> The assignment is redundant and hence can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Applied.