Subject: [PATCH] selftests: kvm: Simplify loop in kvm_create_max_vcpus test

On kvm_create_max_vcpus test remove unneeded local
variable in the loop that add vcpus to the VM.

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
---
tools/testing/selftests/kvm/kvm_create_max_vcpus.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tools/testing/selftests/kvm/kvm_create_max_vcpus.c b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
index 231d79e57774..6f38c3dc0d56 100644
--- a/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
+++ b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
@@ -29,12 +29,9 @@ void test_vcpu_creation(int first_vcpu_id, int num_vcpus)

vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR);

- for (i = 0; i < num_vcpus; i++) {
- int vcpu_id = first_vcpu_id + i;
-
+ for (i = first_vcpu_id; i < first_vcpu_id + num_vcpus; i++)
/* This asserts that the vCPU was created. */
- vm_vcpu_add(vm, vcpu_id);
- }
+ vm_vcpu_add(vm, i);

kvm_vm_free(vm);
}
--
2.18.1


2019-11-14 00:40:48

by Krish Sadhukhan

[permalink] [raw]
Subject: Re: [PATCH] selftests: kvm: Simplify loop in kvm_create_max_vcpus test


On 11/12/19 6:21 AM, Wainer dos Santos Moschetta wrote:
> On kvm_create_max_vcpus test remove unneeded local
> variable in the loop that add vcpus to the VM.
>
> Signed-off-by: Wainer dos Santos Moschetta<[email protected]>
> ---
> tools/testing/selftests/kvm/kvm_create_max_vcpus.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/kvm_create_max_vcpus.c b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
> index 231d79e57774..6f38c3dc0d56 100644
> --- a/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
> +++ b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
> @@ -29,12 +29,9 @@ void test_vcpu_creation(int first_vcpu_id, int num_vcpus)
>
> vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR);
>
> - for (i = 0; i < num_vcpus; i++) {
> - int vcpu_id = first_vcpu_id + i;
> -
> + for (i = first_vcpu_id; i < first_vcpu_id + num_vcpus; i++)
> /* This asserts that the vCPU was created. */
> - vm_vcpu_add(vm, vcpu_id);
> - }
> + vm_vcpu_add(vm, i);
>
> kvm_vm_free(vm);
> }
Reviewed-by: Krish Sadhukhan <[email protected]>

2019-11-14 12:19:25

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [PATCH] selftests: kvm: Simplify loop in kvm_create_max_vcpus test

On 12/11/19 15:21, Wainer dos Santos Moschetta wrote:
> On kvm_create_max_vcpus test remove unneeded local
> variable in the loop that add vcpus to the VM.
>
> Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
> ---
> tools/testing/selftests/kvm/kvm_create_max_vcpus.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/kvm_create_max_vcpus.c b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
> index 231d79e57774..6f38c3dc0d56 100644
> --- a/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
> +++ b/tools/testing/selftests/kvm/kvm_create_max_vcpus.c
> @@ -29,12 +29,9 @@ void test_vcpu_creation(int first_vcpu_id, int num_vcpus)
>
> vm = vm_create(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES, O_RDWR);
>
> - for (i = 0; i < num_vcpus; i++) {
> - int vcpu_id = first_vcpu_id + i;
> -
> + for (i = first_vcpu_id; i < first_vcpu_id + num_vcpus; i++)
> /* This asserts that the vCPU was created. */
> - vm_vcpu_add(vm, vcpu_id);
> - }
> + vm_vcpu_add(vm, i);
>
> kvm_vm_free(vm);
> }
>

Queued, thanks.

Paolo