2019-11-13 05:19:53

by Ruan Shiyang

Subject: [PATCH] mm/memblock: Correct doc for function

From: Cao jin <[email protected]>

Change "max_addr" to "end" for less confusion
in memblock_alloc_range_nid comments.

Signed-off-by: Cao jin <[email protected]>
---
mm/memblock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Suppose this still goes to Andrew's -mm.

diff --git a/mm/memblock.c b/mm/memblock.c
index ceb6761f526d..203ed317551b 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -1321,7 +1321,7 @@ __next_mem_pfn_range_in_zone(u64 *idx, struct zone *zone,
* @nid: nid of the free area to find, %NUMA_NO_NODE for any node
*
* The allocation is performed from memory region limited by
- * memblock.current_limit if @max_addr == %MEMBLOCK_ALLOC_ACCESSIBLE.
+ * memblock.current_limit if @end == %MEMBLOCK_ALLOC_ACCESSIBLE.
*
* If the specified node can not hold the requested memory the
* allocation falls back to any node in the system
--
2.21.0

2019-11-13 10:37:51

by Mike Rapoport

Subject: Re: [PATCH] mm/memblock: Correct doc for function

On Wed, Nov 13, 2019 at 01:18:22PM +0800, Shiyang Ruan wrote:
> From: Cao jin <[email protected]>
>
> Change "max_addr" to "end" for less confusion
> in memblock_alloc_range_nid comments.
>
> Signed-off-by: Cao jin <[email protected]>

Reviewed-by: Mike Rapoport <[email protected]>

> ---
> mm/memblock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Suppose this still goes to Andrew's -mm.
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index ceb6761f526d..203ed317551b 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1321,7 +1321,7 @@ __next_mem_pfn_range_in_zone(u64 *idx, struct zone *zone,
> * @nid: nid of the free area to find, %NUMA_NO_NODE for any node
> *
> * The allocation is performed from memory region limited by
> - * memblock.current_limit if @max_addr == %MEMBLOCK_ALLOC_ACCESSIBLE.
> + * memblock.current_limit if @end == %MEMBLOCK_ALLOC_ACCESSIBLE.
> *
> * If the specified node can not hold the requested memory the
> * allocation falls back to any node in the system
> --
> 2.21.0
>
>
>

--
Sincerely yours,
Mike.