2019-11-13 09:36:17

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH 0/2] mms: Use dma_request_chan() directly for channel request

Hi,

I'm going through the tree to remove dma_request_slave_channel_reason() as it
is just:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)

Regards,
Peter
---
Peter Ujfalusi (2):
mmc: atmel-mci: Use dma_request_chan() directly for channel request
mmc: moxart: Use dma_request_chan() directly for channel request

drivers/mmc/host/atmel-mci.c | 3 +--
drivers/mmc/host/moxart-mmc.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)

--
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


2019-11-13 09:38:33

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH 2/2] mmc: moxart: Use dma_request_chan() directly for channel request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <[email protected]>
---
drivers/mmc/host/moxart-mmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
index a0670e9cd012..fc6b9cf27d0b 100644
--- a/drivers/mmc/host/moxart-mmc.c
+++ b/drivers/mmc/host/moxart-mmc.c
@@ -608,8 +608,8 @@ static int moxart_probe(struct platform_device *pdev)
host->timeout = msecs_to_jiffies(1000);
host->sysclk = clk_get_rate(clk);
host->fifo_width = readl(host->base + REG_FEATURE) << 2;
- host->dma_chan_tx = dma_request_slave_channel_reason(dev, "tx");
- host->dma_chan_rx = dma_request_slave_channel_reason(dev, "rx");
+ host->dma_chan_tx = dma_request_chan(dev, "tx");
+ host->dma_chan_rx = dma_request_chan(dev, "rx");

spin_lock_init(&host->lock);

--
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2019-11-13 09:39:27

by Peter Ujfalusi

[permalink] [raw]
Subject: [PATCH 1/2] mmc: atmel-mci: Use dma_request_chan() directly for channel request

dma_request_slave_channel_reason() is:
#define dma_request_slave_channel_reason(dev, name) \
dma_request_chan(dev, name)

Signed-off-by: Peter Ujfalusi <[email protected]>
---
drivers/mmc/host/atmel-mci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 34c992d87529..6f065bb5c55a 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -2347,8 +2347,7 @@ static void atmci_cleanup_slot(struct atmel_mci_slot *slot,

static int atmci_configure_dma(struct atmel_mci *host)
{
- host->dma.chan = dma_request_slave_channel_reason(&host->pdev->dev,
- "rxtx");
+ host->dma.chan = dma_request_chan(&host->pdev->dev, "rxtx");

if (PTR_ERR(host->dma.chan) == -ENODEV) {
struct mci_platform_data *pdata = host->pdev->dev.platform_data;
--
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

2019-11-13 13:39:33

by Ludovic Desroches

[permalink] [raw]
Subject: Re: [PATCH 1/2] mmc: atmel-mci: Use dma_request_chan() directly for channel request

On Wed, Nov 13, 2019 at 11:36:15AM +0200, Peter Ujfalusi wrote:
>
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)
>
> Signed-off-by: Peter Ujfalusi <[email protected]>
Acked-by: Ludovic Desroches <[email protected]>

Thanks
> ---
> drivers/mmc/host/atmel-mci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 34c992d87529..6f065bb5c55a 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2347,8 +2347,7 @@ static void atmci_cleanup_slot(struct atmel_mci_slot *slot,
>
> static int atmci_configure_dma(struct atmel_mci *host)
> {
> - host->dma.chan = dma_request_slave_channel_reason(&host->pdev->dev,
> - "rxtx");
> + host->dma.chan = dma_request_chan(&host->pdev->dev, "rxtx");
>
> if (PTR_ERR(host->dma.chan) == -ENODEV) {
> struct mci_platform_data *pdata = host->pdev->dev.platform_data;
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
>

2019-11-14 04:36:34

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH 0/2] mms: Use dma_request_chan() directly for channel request

On 13-11-19, 11:36, Peter Ujfalusi wrote:
> Hi,
>
> I'm going through the tree to remove dma_request_slave_channel_reason() as it
> is just:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)

Reviewed-by: Vinod Koul <[email protected]>

--
~Vinod

2019-11-14 12:57:55

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH 0/2] mms: Use dma_request_chan() directly for channel request

On Wed, 13 Nov 2019 at 10:35, Peter Ujfalusi <[email protected]> wrote:
>
> Hi,
>
> I'm going through the tree to remove dma_request_slave_channel_reason() as it
> is just:
> #define dma_request_slave_channel_reason(dev, name) \
> dma_request_chan(dev, name)
>
> Regards,
> Peter
> ---
> Peter Ujfalusi (2):
> mmc: atmel-mci: Use dma_request_chan() directly for channel request
> mmc: moxart: Use dma_request_chan() directly for channel request
>
> drivers/mmc/host/atmel-mci.c | 3 +--
> drivers/mmc/host/moxart-mmc.c | 4 ++--
> 2 files changed, 3 insertions(+), 4 deletions(-)

Applied for next, thanks!

Kind regards
Uffe