2019-11-14 07:42:01

by Yue Haibing

Subject: [PATCH net-next] net/tls: Fix unused function warning

If PROC_FS is not set, gcc warning this:

net/tls/tls_proc.c:23:12: warning:
'tls_statistics_seq_show' defined but not used [-Wunused-function]

Use #ifdef to guard this.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: YueHaibing <[email protected]>
---
net/tls/tls_proc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/tls/tls_proc.c b/net/tls/tls_proc.c
index 83d9c80..3a5dd1e 100644
--- a/net/tls/tls_proc.c
+++ b/net/tls/tls_proc.c
@@ -6,6 +6,7 @@
#include <net/snmp.h>
#include <net/tls.h>

+#ifdef CONFIG_PROC_FS
static const struct snmp_mib tls_mib_list[] = {
SNMP_MIB_ITEM("TlsCurrTxSw", LINUX_MIB_TLSCURRTXSW),
SNMP_MIB_ITEM("TlsCurrRxSw", LINUX_MIB_TLSCURRRXSW),
@@ -32,6 +33,7 @@ static int tls_statistics_seq_show(struct seq_file *seq, void *v)

return 0;
}
+#endif

int __net_init tls_proc_init(struct net *net)
{
--
2.7.4

2019-11-14 17:04:32

by Jakub Kicinski

Subject: Re: [PATCH net-next] net/tls: Fix unused function warning

On Thu, 14 Nov 2019 15:39:46 +0800, YueHaibing wrote:
> If PROC_FS is not set, gcc warning this:
>
> net/tls/tls_proc.c:23:12: warning:
> 'tls_statistics_seq_show' defined but not used [-Wunused-function]
>
> Use #ifdef to guard this.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Acked-by: Jakub Kicinski <[email protected]>

2019-11-15 20:15:16

by David Miller

Subject: Re: [PATCH net-next] net/tls: Fix unused function warning

From: YueHaibing <[email protected]>
Date: Thu, 14 Nov 2019 15:39:46 +0800

> If PROC_FS is not set, gcc warning this:
>
> net/tls/tls_proc.c:23:12: warning:
> 'tls_statistics_seq_show' defined but not used [-Wunused-function]
>
> Use #ifdef to guard this.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: YueHaibing <[email protected]>

Applied.