2019-10-02 06:12:02

by Nayna Jain

Subject: [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro

This patch fixes the size and write parameter for the macro
__BIN_ATTR_WO().

Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
Signed-off-by: Nayna Jain <[email protected]>
---
include/linux/sysfs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 5420817ed317..fa7ee503fb76 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -196,9 +196,9 @@ struct bin_attribute {
.size = _size, \
}

-#define __BIN_ATTR_WO(_name) { \
+#define __BIN_ATTR_WO(_name, _size) { \
.attr = { .name = __stringify(_name), .mode = 0200 }, \
- .store = _name##_store, \
+ .write = _name##_write, \
.size = _size, \
}

--
2.20.1

2019-11-14 09:11:25

by Michael Ellerman

Subject: Re: [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro

On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote:
> This patch fixes the size and write parameter for the macro
> __BIN_ATTR_WO().
>
> Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
> Signed-off-by: Nayna Jain <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/39a963b457b5c6cbbdc70441c9d496e39d151582

cheers

2019-11-14 09:49:05

by Greg Kroah-Hartman

Subject: Re: [PATCH] sysfs: Fixes __BIN_ATTR_WO() macro

On Thu, Nov 14, 2019 at 08:07:49PM +1100, Michael Ellerman wrote:
> On Tue, 2019-10-01 at 23:37:18 UTC, Nayna Jain wrote:
> > This patch fixes the size and write parameter for the macro
> > __BIN_ATTR_WO().
> >
> > Fixes: 7f905761e15a8 ("sysfs: add BIN_ATTR_WO() macro")
> > Signed-off-by: Nayna Jain <[email protected]>
>
> Applied to powerpc next, thanks.
>
> https://git.kernel.org/powerpc/c/39a963b457b5c6cbbdc70441c9d496e39d151582

Why? This is already in 5.4-rc5, why do you need/want it again?

thanks,

greg k-h