2019-11-14 10:05:42

by Uwe Kleine-König

Subject: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

This extension was introduced in commit 57f5677e535b ("printf: add
support for printing symbolic error names").

Signed-off-by: Uwe Kleine-König <[email protected]>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6fcc66afb088..31cd9b767c1e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6022,7 +6022,7 @@ sub process {
while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
$specifier = $1;
$extension = $2;
- if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
+ if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
$bad_specifier = $specifier;
last;
}
--
2.24.0

2019-11-14 10:16:05

by Rasmus Villemoes

Subject: Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

On 14/11/2019 11.04, Uwe Kleine-König wrote:
> This extension was introduced in commit 57f5677e535b ("printf: add
> support for printing symbolic error names").
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Ack, of course. Petr, I think it makes most sense if this goes via your
tree unless there are other checkpatch patches touching the same place
(which I doubt, as I think we'd know about other new extensions).

Rasmus

2019-11-14 10:26:14

by Petr Mladek

Subject: Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

On Thu 2019-11-14 11:04:16, Uwe Kleine-K?nig wrote:
> This extension was introduced in commit 57f5677e535b ("printf: add
> support for printing symbolic error names").

Great catch!

> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb088..31cd9b767c1e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6022,7 +6022,7 @@ sub process {
> while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> $specifier = $1;
> $extension = $2;
> - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> + if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {

I am going to push it into printk.git. I will just change the ordering
"eE" -> "Ee". So that it follows the existing convention.

Best Regards,
Petr

2019-11-14 10:37:41

by Uwe Kleine-König

Subject: Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote:
> On Thu 2019-11-14 11:04:16, Uwe Kleine-K?nig wrote:
> > This extension was introduced in commit 57f5677e535b ("printf: add
> > support for printing symbolic error names").
>
> Great catch!

It wasn't hard to catch. checkpatch pelted me with bogus warnings when I
started to make use of %pe :-)

> > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> > ---
> > scripts/checkpatch.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 6fcc66afb088..31cd9b767c1e 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -6022,7 +6022,7 @@ sub process {
> > while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> > $specifier = $1;
> > $extension = $2;
> > - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> > + if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
>
> I am going to push it into printk.git. I will just change the ordering
> "eE" -> "Ee". So that it follows the existing convention.

Fine for me. Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |

2019-11-14 14:04:27

by Petr Mladek

Subject: Re: [PATCH] checkpatch: don't warn about new vsprintf pointer extension '%pe'

On Thu 2019-11-14 11:33:50, Uwe Kleine-K?nig wrote:
> On Thu, Nov 14, 2019 at 11:24:40AM +0100, Petr Mladek wrote:
> > On Thu 2019-11-14 11:04:16, Uwe Kleine-K?nig wrote:
> > > This extension was introduced in commit 57f5677e535b ("printf: add
> > > support for printing symbolic error names").
> >
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > index 6fcc66afb088..31cd9b767c1e 100755
> > > --- a/scripts/checkpatch.pl
> > > +++ b/scripts/checkpatch.pl
> > > @@ -6022,7 +6022,7 @@ sub process {
> > > while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> > > $specifier = $1;
> > > $extension = $2;
> > > - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxt]/) {
> > > + if ($extension !~ /[SsBKRraeEhMmIiUDdgVCbGNOxt]/) {
> >
> > I am going to push it into printk.git. I will just change the ordering
> > "eE" -> "Ee". So that it follows the existing convention.
>
> Fine for me. Thanks

The patch is committed in printk.git, branch for-5.5.

Best Regards,
Petr