2019-11-15 03:23:49

by Gao Xiang

[permalink] [raw]
Subject: Re: [PATCH v2] ext4: bio_alloc with __GFP_DIRECT_RECLAIM never fails

Hi Ted,

On Thu, Nov 14, 2019 at 10:19:53PM -0500, Theodore Y. Ts'o wrote:
> On Thu, Oct 31, 2019 at 05:29:58PM +0800, Chao Yu wrote:
> > On 2019/10/31 17:23, Gao Xiang wrote:
> > > Similar to [1] [2], bio_alloc with __GFP_DIRECT_RECLAIM flags
> > > guarantees bio allocation under some given restrictions, as
> > > stated in block/bio.c and fs/direct-io.c So here it's ok to
> > > not check for NULL value from bio_alloc().
> > >
> > > [1] https://lore.kernel.org/r/[email protected]
> > > [2] https://lore.kernel.org/r/[email protected]
> > > Cc: Theodore Ts'o <[email protected]>
> > > Cc: Andreas Dilger <[email protected]>
> > > Cc: Ritesh Harjani <[email protected]>
> > > Cc: Chao Yu <[email protected]>
> > > Signed-off-by: Gao Xiang <[email protected]>
> >
> > Reviewed-by: Chao Yu <[email protected]>
>
> Thanks, applied.
>
> - Ted

Thanks for considering this. Have a nice day.

Thanks,
Gao Xiang