From: Cao jin <[email protected]>
ACPI BOOT table is initialized in both acpi_boot_table_init &
acpi_boot_init of setup_arch, but its usage is quite late at the end of
start_kernel. It should be safe to drop one of them. Since it is less
related with table init, drop it from there.
Signed-off-by: Cao jin <[email protected]>
---
arch/x86/kernel/acpi/boot.c | 2 --
1 file changed, 2 deletions(-)
It existed since git repo is built, so it might has its reason? The
patch is not tested since I don't have BOOT table in my firmware.
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 04205ce127a1..ca1c15bb0b48 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1558,8 +1558,6 @@ void __init acpi_boot_table_init(void)
return;
}
- acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
-
/*
* blacklist may disable ACPI entirely
*/
--
2.21.0
On Fri, Nov 15, 2019 at 6:06 AM Shiyang Ruan <[email protected]> wrote:
>
> From: Cao jin <[email protected]>
>
> ACPI BOOT table is initialized in both acpi_boot_table_init &
> acpi_boot_init of setup_arch, but its usage is quite late at the end of
> start_kernel. It should be safe to drop one of them. Since it is less
> related with table init, drop it from there.
>
> Signed-off-by: Cao jin <[email protected]>
Please resend with a CC to [email protected]
> ---
> arch/x86/kernel/acpi/boot.c | 2 --
> 1 file changed, 2 deletions(-)
>
> It existed since git repo is built, so it might has its reason? The
> patch is not tested since I don't have BOOT table in my firmware.
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 04205ce127a1..ca1c15bb0b48 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -1558,8 +1558,6 @@ void __init acpi_boot_table_init(void)
> return;
> }
>
> - acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
> -
> /*
> * blacklist may disable ACPI entirely
> */
> --
> 2.21.0
>
>
>
On 11/15/19 5:09 PM, Rafael J. Wysocki wrote:
> On Fri, Nov 15, 2019 at 6:06 AM Shiyang Ruan <[email protected]> wrote:
>>
>> From: Cao jin <[email protected]>
>>
>> ACPI BOOT table is initialized in both acpi_boot_table_init &
>> acpi_boot_init of setup_arch, but its usage is quite late at the end of
>> start_kernel. It should be safe to drop one of them. Since it is less
>> related with table init, drop it from there.
>>
>> Signed-off-by: Cao jin <[email protected]>
>
> Please resend with a CC to [email protected]
>
Sure. It is better to let get_maintainer.pl tell the whole list.
--
Sincerely,
Cao jin