2019-11-15 13:29:03

by Steven Rostedt

Subject: [for-next][PATCH] tracing: Add missing "inline" in stub function of latency_fsnotify()

From: "Steven Rostedt (VMware)" <[email protected]>

The latency_fsnotify() stub when the function is not defined, was missing
the "inline".

Link: https://lore.kernel.org/r/[email protected]

Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Steven Rostedt (VMware) <[email protected]>
---
kernel/trace/trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
index 90cba68c8b50..2df8aed6a8f0 100644
--- a/kernel/trace/trace.h
+++ b/kernel/trace/trace.h
@@ -801,7 +801,7 @@ void latency_fsnotify(struct trace_array *tr);

#else

-static void latency_fsnotify(struct trace_array *tr) { }
+static inline void latency_fsnotify(struct trace_array *tr) { }

#endif

--
2.20.1

2019-11-15 13:47:46

by Viktor Rosendahl

Subject: Re: [for-next][PATCH] tracing: Add missing "inline" in stub function of latency_fsnotify()

On 11/15/19 2:27 PM, Steven Rostedt wrote:

> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index 90cba68c8b50..2df8aed6a8f0 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -801,7 +801,7 @@ void latency_fsnotify(struct trace_array *tr);
>
> #else
>
> -static void latency_fsnotify(struct trace_array *tr) { }
> +static inline void latency_fsnotify(struct trace_array *tr) { }
>
> #endif
>
>

Looks good to me.

Thanks for fixing this.

best regards,

Viktor