2019-11-15 08:33:03

by Chuhong Yuan

Subject: [PATCH 1/2] dmaengine: mmp_tdma: add missed of_dma_controller_free

The driver calls of_dma_controller_register in probe but does not free
it in remove.
Add the call to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/dma/mmp_tdma.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index e7d1e12bf464..10117f271b12 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -544,6 +544,9 @@ static void mmp_tdma_issue_pending(struct dma_chan *chan)

static int mmp_tdma_remove(struct platform_device *pdev)
{
+ if (pdev->dev.of_node)
+ of_dma_controller_free(pdev->dev.of_node);
+
return 0;
}

--
2.24.0

2019-11-22 05:24:27

by Vinod Koul

Subject: Re: [PATCH 1/2] dmaengine: mmp_tdma: add missed of_dma_controller_free

On 15-11-19, 16:31, Chuhong Yuan wrote:
> The driver calls of_dma_controller_register in probe but does not free
> it in remove.
> Add the call to fix it.

Applied both, thanks.

--
~Vinod