2019-11-19 03:28:41

by Mao Wenan

Subject: [PATCH -next] vsock/vmci: make vmci_vsock_cb_host_called static

When using make C=2 drivers/misc/vmw_vmci/vmci_driver.o
to compile, below warning can be seen:
drivers/misc/vmw_vmci/vmci_driver.c:33:6: warning:
symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?

This patch make symbol vmci_vsock_cb_host_called static.

Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Mao Wenan <[email protected]>
---
drivers/misc/vmw_vmci/vmci_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
index 95fed46..cbb706d 100644
--- a/drivers/misc/vmw_vmci/vmci_driver.c
+++ b/drivers/misc/vmw_vmci/vmci_driver.c
@@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;

static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
static vmci_vsock_cb vmci_vsock_transport_cb;
-bool vmci_vsock_cb_host_called;
+static bool vmci_vsock_cb_host_called;

/*
* vmci_get_context_id() - Gets the current context ID.
--
2.7.4

2019-11-19 08:16:04

by Stefano Garzarella

Subject: Re: [PATCH -next] vsock/vmci: make vmci_vsock_cb_host_called static

On Tue, Nov 19, 2019 at 11:25:34AM +0800, Mao Wenan wrote:
> When using make C=2 drivers/misc/vmw_vmci/vmci_driver.o
> to compile, below warning can be seen:
> drivers/misc/vmw_vmci/vmci_driver.c:33:6: warning:
> symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static?
>
> This patch make symbol vmci_vsock_cb_host_called static.
>
> Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Mao Wenan <[email protected]>
> ---
> drivers/misc/vmw_vmci/vmci_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c
> index 95fed46..cbb706d 100644
> --- a/drivers/misc/vmw_vmci/vmci_driver.c
> +++ b/drivers/misc/vmw_vmci/vmci_driver.c
> @@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized;
>
> static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */
> static vmci_vsock_cb vmci_vsock_transport_cb;
> -bool vmci_vsock_cb_host_called;
> +static bool vmci_vsock_cb_host_called;
>
> /*
> * vmci_get_context_id() - Gets the current context ID.
> --
> 2.7.4
>

Same patch already sent by "kbuild test robot" <[email protected]>
https://lkml.org/lkml/2019/11/18/609

If we want to merge this, maybe we can also add:
Reported-by: kbuild test robot <[email protected]>

Anyway, it is my fault:
Reviewed-by: Stefano Garzarella <[email protected]>