2019-11-20 21:15:37

by Michael Grzeschik

Subject: [PATCH v3 1/2] ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file

The usb port represented by &usbhost1 uses an USB phy internal to the
SoC. We add the phy_type to the base dtsi so the board dts only have to
overwrite it if they use a different configuration. While at it we also
pin the usbhost port to host mode.

Signed-off-by: Michael Grzeschik <[email protected]>
---
v1 -> v2: - added the maximum speed limitation of the internal phy

v2 -> v3: - moved phy speed limitation to extra patch
- reworded subject line

arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts | 2 --
arch/arm/boot/dts/imx25-pdk.dts | 2 --
arch/arm/boot/dts/imx25.dtsi | 2 ++
3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts b/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts
index 0fde90df2b546..3f38c2e60a745 100644
--- a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts
+++ b/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts
@@ -165,8 +165,6 @@
};

&usbhost1 {
- phy_type = "serial";
- dr_mode = "host";
status = "okay";
};

diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts
index 05cccd12624cb..fb66884d8a2fa 100644
--- a/arch/arm/boot/dts/imx25-pdk.dts
+++ b/arch/arm/boot/dts/imx25-pdk.dts
@@ -304,8 +304,6 @@
};

&usbhost1 {
- phy_type = "serial";
- dr_mode = "host";
status = "okay";
};

diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index 9a097ef014af5..7c7795b40ee0c 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -570,6 +570,8 @@
clock-names = "ipg", "ahb", "per";
fsl,usbmisc = <&usbmisc 1>;
fsl,usbphy = <&usbphy1>;
+ phy_type = "serial";
+ dr_mode = "host";
status = "disabled";
};

--
2.24.0

2019-11-20 21:30:11

by Fabio Estevam

Subject: Re: [PATCH v3 1/2] ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file

On Wed, Nov 20, 2019 at 6:14 PM Michael Grzeschik
<[email protected]> wrote:
>
> The usb port represented by &usbhost1 uses an USB phy internal to the
> SoC. We add the phy_type to the base dtsi so the board dts only have to
> overwrite it if they use a different configuration. While at it we also
> pin the usbhost port to host mode.
>
> Signed-off-by: Michael Grzeschik <[email protected]>

Reviewed-by: Fabio Estevam <[email protected]>