2019-11-21 01:43:41

by Lichao Liu

Subject: [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.

Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
to control whether to include the asm/i8259.h header file.

Signed-off-by: Lichao Liu <[email protected]>
---
arch/mips/loongson64/common/pm.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/mips/loongson64/common/pm.c b/arch/mips/loongson64/common/pm.c
index b8aed878d..bc619e4d0 100644
--- a/arch/mips/loongson64/common/pm.c
+++ b/arch/mips/loongson64/common/pm.c
@@ -9,7 +9,9 @@
#include <linux/interrupt.h>
#include <linux/pm.h>

+#ifdef CONFIG_I8259
#include <asm/i8259.h>
+#endif
#include <asm/mipsregs.h>

#include <loongson.h>
--
2.17.1

2019-11-21 06:14:32

by Jiaxun Yang

Subject: Re: [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.

于 2019年11月21日 GMT+08:00 上午9:41:56, Lichao Liu <[email protected]> 写到:
>Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
>to control whether to include the asm/i8259.h header file.
>
>Signed-off-by: Lichao Liu <[email protected]>

Acked-by: Jiaxun Yang <[email protected]>

I'm glad to see Loongson guys finally get here.

I will send v3 of my previous "modernize" set.
Which will also refactor interrupt part.
Do you have any comments based on v2 [1]?

[1]: https://patchwork.kernel.org/cover/11133237/
>---
> arch/mips/loongson64/common/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/mips/loongson64/common/pm.c
>b/arch/mips/loongson64/common/pm.c
>index b8aed878d..bc619e4d0 100644
>--- a/arch/mips/loongson64/common/pm.c
>+++ b/arch/mips/loongson64/common/pm.c
>@@ -9,7 +9,9 @@
> #include <linux/interrupt.h>
> #include <linux/pm.h>
>
>+#ifdef CONFIG_I8259
> #include <asm/i8259.h>
>+#endif
> #include <asm/mipsregs.h>
>
> #include <loongson.h>

--
Jiaxun Yang

2019-11-21 06:19:08

by Jiaxun Yang

Subject: Re: [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.

于 2019年11月21日 GMT+08:00 上午9:41:56, Lichao Liu <[email protected]> 写到:
>Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
>to control whether to include the asm/i8259.h header file.

You should have a dedicated short patch tittle.

Like MIPS: Loongson64: Limit i8259 include by config

>
>Signed-off-by: Lichao Liu <[email protected]>
>---
> arch/mips/loongson64/common/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/mips/loongson64/common/pm.c
>b/arch/mips/loongson64/common/pm.c
>index b8aed878d..bc619e4d0 100644
>--- a/arch/mips/loongson64/common/pm.c
>+++ b/arch/mips/loongson64/common/pm.c
>@@ -9,7 +9,9 @@
> #include <linux/interrupt.h>
> #include <linux/pm.h>
>
>+#ifdef CONFIG_I8259
> #include <asm/i8259.h>
>+#endif
> #include <asm/mipsregs.h>
>
> #include <loongson.h>

--
Jiaxun Yang