2019-11-23 16:06:48

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH v2 05/16] scripts/kallsyms: remove redundant is_arm_mapping_symbol()

Since commit 6f00df24ee39 ("[PATCH] Strip local symbols from kallsyms"),
all symbols starting '$' are ignored.

is_arm_mapping_symbol() particularly ignores $a, $t, etc. but it is
redundant.

Signed-off-by: Masahiro Yamada <[email protected]>
---

Changes in v2: None

scripts/kallsyms.c | 19 ++++++-------------
1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index c9efb67c6ecb..14a50c8d3f34 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -74,16 +74,6 @@ static void usage(void)
exit(1);
}

-/*
- * This ignores the intensely annoying "mapping symbols" found
- * in ARM ELF files: $a, $t and $d.
- */
-static int is_arm_mapping_symbol(const char *str)
-{
- return str[0] == '$' && strchr("axtd", str[1])
- && (str[2] == '\0' || str[2] == '.');
-}
-
static int check_symbol_range(const char *sym, unsigned long long addr,
struct addr_range *ranges, int entries)
{
@@ -139,10 +129,13 @@ static int read_symbol(FILE *in, struct sym_entry *s)
return -1;

}
- else if (toupper(stype) == 'U' ||
- is_arm_mapping_symbol(sym))
+ else if (toupper(stype) == 'U')
return -1;
- /* exclude also MIPS ELF local symbols ($L123 instead of .L123) */
+ /*
+ * Ignore generated symbols such as:
+ * - mapping symbols in ARM ELF files ($a, $t, and $d)
+ * - MIPS ELF local symbols ($L123 instead of .L123)
+ */
else if (sym[0] == '$')
return -1;
/* exclude debugging symbols */
--
2.17.1