From: Eric Dumazet <[email protected]>
A patch in net-next triggered a compile error on powerpc:
include/linux/u64_stats_sync.h: In function 'u64_stats_read':
include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
This seems reasonable to relax powerpc local_read() requirements.
Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
Signed-off-by: Eric Dumazet <[email protected]>
Reported-by: kbuild test robot <[email protected]>
Acked-by: Michael Ellerman <[email protected]>
---
arch/powerpc/include/asm/local.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v2: mpe: Update change log with compiler warning, resend to netdev so it appears
in the netdev patchwork.
Dave can you take this in the net tree so the window of the breakage is as small
as possible please?
diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
index fdd00939270b..bc4bd19b7fc2 100644
--- a/arch/powerpc/include/asm/local.h
+++ b/arch/powerpc/include/asm/local.h
@@ -17,7 +17,7 @@ typedef struct
#define LOCAL_INIT(i) { (i) }
-static __inline__ long local_read(local_t *l)
+static __inline__ long local_read(const local_t *l)
{
return READ_ONCE(l->v);
}
--
2.21.0
Hi all,
On Wed, 20 Nov 2019 12:14:51 +1100 Michael Ellerman <[email protected]> wrote:
>
> From: Eric Dumazet <[email protected]>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Acked-by: Michael Ellerman <[email protected]>
Tested-by: Stephen Rothwell <[email protected]> # build only
--
Cheers,
Stephen Rothwell
Hi Dave,
On Wed, 20 Nov 2019 12:14:51 +1100 Michael Ellerman <[email protected]> wrote:
>
> From: Eric Dumazet <[email protected]>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Acked-by: Michael Ellerman <[email protected]>
> ---
> arch/powerpc/include/asm/local.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v2: mpe: Update change log with compiler warning, resend to netdev so it appears
> in the netdev patchwork.
>
> Dave can you take this in the net tree so the window of the breakage is as small
> as possible please?
I see that you marked this as "Not Applicable" in patchwork.
Michael meant the net-next tree which contains commit
316580b69d0a ("u64_stats: provide u64_stats_t type")
Please consider applying this patch.
> diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h
> index fdd00939270b..bc4bd19b7fc2 100644
> --- a/arch/powerpc/include/asm/local.h
> +++ b/arch/powerpc/include/asm/local.h
> @@ -17,7 +17,7 @@ typedef struct
>
> #define LOCAL_INIT(i) { (i) }
>
> -static __inline__ long local_read(local_t *l)
> +static __inline__ long local_read(const local_t *l)
> {
> return READ_ONCE(l->v);
> }
> --
> 2.21.0
>
--
Cheers,
Stephen Rothwell
On Wed, 20 Nov 2019 12:14:51 +1100, Michael Ellerman wrote:
> From: Eric Dumazet <[email protected]>
>
> A patch in net-next triggered a compile error on powerpc:
>
> include/linux/u64_stats_sync.h: In function 'u64_stats_read':
> include/asm-generic/local64.h:30:37: warning: passing argument 1 of 'local_read' discards 'const' qualifier from pointer target type
>
> This seems reasonable to relax powerpc local_read() requirements.
>
> Fixes: 316580b69d0a ("u64_stats: provide u64_stats_t type")
> Signed-off-by: Eric Dumazet <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Acked-by: Michael Ellerman <[email protected]>
Applied to net-next now, thanks.