2019-11-21 13:32:48

by Krzysztof Kozlowski

Subject: [PATCH] drm/vc4: Fix Kconfig indentation

Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^ /\t/' -i */Kconfig

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/vc4/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
index 7c2317efd5b7..118e8a426b1a 100644
--- a/drivers/gpu/drm/vc4/Kconfig
+++ b/drivers/gpu/drm/vc4/Kconfig
@@ -22,9 +22,9 @@ config DRM_VC4
our display setup.

config DRM_VC4_HDMI_CEC
- bool "Broadcom VC4 HDMI CEC Support"
- depends on DRM_VC4
- select CEC_CORE
- help
+ bool "Broadcom VC4 HDMI CEC Support"
+ depends on DRM_VC4
+ select CEC_CORE
+ help
Choose this option if you have a Broadcom VC4 GPU
and want to use CEC.
--
2.17.1

2019-11-25 09:13:11

by Daniel Vetter

Subject: Re: [PATCH] drm/vc4: Fix Kconfig indentation

On Thu, Nov 21, 2019 at 09:29:19PM +0800, Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> $ sed -e 's/^ /\t/' -i */Kconfig
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Queued in drm-misc-next for 5.6, thanks for your patch.
-Daniel

> ---
> drivers/gpu/drm/vc4/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
> index 7c2317efd5b7..118e8a426b1a 100644
> --- a/drivers/gpu/drm/vc4/Kconfig
> +++ b/drivers/gpu/drm/vc4/Kconfig
> @@ -22,9 +22,9 @@ config DRM_VC4
> our display setup.
>
> config DRM_VC4_HDMI_CEC
> - bool "Broadcom VC4 HDMI CEC Support"
> - depends on DRM_VC4
> - select CEC_CORE
> - help
> + bool "Broadcom VC4 HDMI CEC Support"
> + depends on DRM_VC4
> + select CEC_CORE
> + help
> Choose this option if you have a Broadcom VC4 GPU
> and want to use CEC.
> --
> 2.17.1
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2019-11-27 13:17:06

by Jani Nikula

Subject: Re: [PATCH] drm/vc4: Fix Kconfig indentation

On Thu, 21 Nov 2019, Krzysztof Kozlowski <[email protected]> wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> $ sed -e 's/^ /\t/' -i */Kconfig

Btw have you updated checkpatch.pl to try to keep the Kconfigs from
bitrotting back to having different indentation? Or the config tools?

BR,
Jani.


>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/vc4/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/Kconfig b/drivers/gpu/drm/vc4/Kconfig
> index 7c2317efd5b7..118e8a426b1a 100644
> --- a/drivers/gpu/drm/vc4/Kconfig
> +++ b/drivers/gpu/drm/vc4/Kconfig
> @@ -22,9 +22,9 @@ config DRM_VC4
> our display setup.
>
> config DRM_VC4_HDMI_CEC
> - bool "Broadcom VC4 HDMI CEC Support"
> - depends on DRM_VC4
> - select CEC_CORE
> - help
> + bool "Broadcom VC4 HDMI CEC Support"
> + depends on DRM_VC4
> + select CEC_CORE
> + help
> Choose this option if you have a Broadcom VC4 GPU
> and want to use CEC.

--
Jani Nikula, Intel Open Source Graphics Center

2019-11-28 02:03:21

by Krzysztof Kozlowski

Subject: Re: [PATCH] drm/vc4: Fix Kconfig indentation

On Wed, 27 Nov 2019 at 21:14, Jani Nikula <[email protected]> wrote:
>
> On Thu, 21 Nov 2019, Krzysztof Kozlowski <[email protected]> wrote:
> > Adjust indentation from spaces to tab (+optional two spaces) as in
> > coding style with command like:
> > $ sed -e 's/^ /\t/' -i */Kconfig
>
> Btw have you updated checkpatch.pl to try to keep the Kconfigs from
> bitrotting back to having different indentation? Or the config tools?

Perl is not my domain but I can try. Let's see...

Best regards,
Krzysztof