2019-11-25 18:27:35

by Hao Lee

Subject: [PATCH] mm: fix comments related to node reclaim

As zone reclaim has been replaced by node reclaim, this patch fixes related
comments.

Signed-off-by: Hao Lee <[email protected]>
---
include/linux/mmzone.h | 2 +-
include/uapi/linux/capability.h | 2 +-
include/uapi/linux/sysctl.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 9e47289a4511..7e3208f4f5bc 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -747,7 +747,7 @@ typedef struct pglist_data {

#ifdef CONFIG_NUMA
/*
- * zone reclaim becomes active if more unmapped pages exist.
+ * node reclaim becomes active if more unmapped pages exist.
*/
unsigned long min_unmapped_pages;
unsigned long min_slab_pages;
diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
index 240fdb9a60f6..dd6772f16eec 100644
--- a/include/uapi/linux/capability.h
+++ b/include/uapi/linux/capability.h
@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
/* Allow enabling/disabling tagged queuing on SCSI controllers and sending
arbitrary SCSI commands */
/* Allow setting encryption key on loopback filesystem */
-/* Allow setting zone reclaim policy */
+/* Allow setting node reclaim policy */

#define CAP_SYS_ADMIN 21

diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
index 87aa2a6d9125..27c1ed2822e6 100644
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
@@ -195,7 +195,7 @@ enum
VM_MIN_UNMAPPED=32, /* Set min percent of unmapped pages */
VM_PANIC_ON_OOM=33, /* panic at out-of-memory */
VM_VDSO_ENABLED=34, /* map VDSO into new processes? */
- VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */
+ VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */
};


--
2.14.5

2019-11-26 09:44:06

by Anshuman Khandual

Subject: Re: [PATCH] mm: fix comments related to node reclaim

On 11/25/2019 07:50 PM, Hao Lee wrote:
> As zone reclaim has been replaced by node reclaim, this patch fixes related
> comments.
>
> Signed-off-by: Hao Lee <[email protected]>
> ---
> include/linux/mmzone.h | 2 +-
> include/uapi/linux/capability.h | 2 +-
> include/uapi/linux/sysctl.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 9e47289a4511..7e3208f4f5bc 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -747,7 +747,7 @@ typedef struct pglist_data {
>
> #ifdef CONFIG_NUMA
> /*
> - * zone reclaim becomes active if more unmapped pages exist.
> + * node reclaim becomes active if more unmapped pages exist.
> */
> unsigned long min_unmapped_pages;
> unsigned long min_slab_pages;
> diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
> index 240fdb9a60f6..dd6772f16eec 100644
> --- a/include/uapi/linux/capability.h
> +++ b/include/uapi/linux/capability.h
> @@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
> /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
> arbitrary SCSI commands */
> /* Allow setting encryption key on loopback filesystem */
> -/* Allow setting zone reclaim policy */
> +/* Allow setting node reclaim policy */

Does this point to the capability for accessing vm.zone_reclaim_mode = 0
sysctl knob ? In that case we should not be changing the name here as the
interface still retains the original name 'zone_reclaim_mode'.

>
> #define CAP_SYS_ADMIN 21
>
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index 87aa2a6d9125..27c1ed2822e6 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -195,7 +195,7 @@ enum
> VM_MIN_UNMAPPED=32, /* Set min percent of unmapped pages */
> VM_PANIC_ON_OOM=33, /* panic at out-of-memory */
> VM_VDSO_ENABLED=34, /* map VDSO into new processes? */
> - VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */
> + VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */
> };
>
>
>

2019-11-26 14:35:00

by Hao Lee

Subject: Re: [PATCH] mm: fix comments related to node reclaim

On Tue, 26 Nov 2019 at 17:42, Anshuman Khandual
<[email protected]> wrote:
> On 11/25/2019 07:50 PM, Hao Lee wrote:
> > --- a/include/uapi/linux/capability.h
> > +++ b/include/uapi/linux/capability.h
> > @@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
> > /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
> > arbitrary SCSI commands */
> > /* Allow setting encryption key on loopback filesystem */
> > -/* Allow setting zone reclaim policy */
> > +/* Allow setting node reclaim policy */
>
> Does this point to the capability for accessing vm.zone_reclaim_mode = 0
> sysctl knob ? In that case we should not be changing the name here as the
> interface still retains the original name 'zone_reclaim_mode'.

Yes. This comment should be consistent with sysctl documentation and
interface. Thanks for your correction!