2019-11-27 17:10:11

by Mihail Atanassov

[permalink] [raw]
Subject: [PATCH] drm/mediatek: Fix build break

Caused by file removal without adjusting the Makefile.

Fixes: d268f42e6856 ("drm/mediatek: don't open-code drm_gem_fb_create")
Cc: Daniel Vetter <[email protected]>
Cc: CK Hu <[email protected]>
Cc: Philipp Zabel <[email protected]>
Cc: Matthias Brugger <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Mihail Atanassov <[email protected]>
---
drivers/gpu/drm/mediatek/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
index 8067a4be8311..5044dfb8e3d6 100644
--- a/drivers/gpu/drm/mediatek/Makefile
+++ b/drivers/gpu/drm/mediatek/Makefile
@@ -7,7 +7,6 @@ mediatek-drm-y := mtk_disp_color.o \
mtk_drm_ddp.o \
mtk_drm_ddp_comp.o \
mtk_drm_drv.o \
- mtk_drm_fb.o \
mtk_drm_gem.o \
mtk_drm_plane.o \
mtk_dsi.o \
--
2.23.0


2019-11-27 18:12:19

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] drm/mediatek: Fix build break

On Wed, Nov 27, 2019 at 05:05:32PM +0000, Mihail Atanassov wrote:
> Caused by file removal without adjusting the Makefile.
>
> Fixes: d268f42e6856 ("drm/mediatek: don't open-code drm_gem_fb_create")
> Cc: Daniel Vetter <[email protected]>
> Cc: CK Hu <[email protected]>
> Cc: Philipp Zabel <[email protected]>
> Cc: Matthias Brugger <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Mihail Atanassov <[email protected]>

Drat, kbuild still sucks if you dont do a clean rebuild :-/

Thanks for the patch, I pushed it.
-Daniel
> ---
> drivers/gpu/drm/mediatek/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
> index 8067a4be8311..5044dfb8e3d6 100644
> --- a/drivers/gpu/drm/mediatek/Makefile
> +++ b/drivers/gpu/drm/mediatek/Makefile
> @@ -7,7 +7,6 @@ mediatek-drm-y := mtk_disp_color.o \
> mtk_drm_ddp.o \
> mtk_drm_ddp_comp.o \
> mtk_drm_drv.o \
> - mtk_drm_fb.o \
> mtk_drm_gem.o \
> mtk_drm_plane.o \
> mtk_dsi.o \
> --
> 2.23.0
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch