2019-11-27 17:21:04

by Olivier Moysan

Subject: [PATCH] dt-bindings: iio: adc: convert sd modulator to json-schema

Convert the sigma delta modulator bindings
to DT schema format using json-schema.

Signed-off-by: Olivier Moysan <[email protected]>
---
.../iio/adc/sigma-delta-modulator.txt | 13 -------
.../iio/adc/sigma-delta-modulator.yaml | 35 +++++++++++++++++++
2 files changed, 35 insertions(+), 13 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
create mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml

diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
deleted file mode 100644
index 59b92cd32552..000000000000
--- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-Device-Tree bindings for sigma delta modulator
-
-Required properties:
-- compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
- as a generic SD modulator if modulator not specified in compatible list.
-- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
-
-Example node:
-
- ads1202: adc {
- compatible = "sd-modulator";
- #io-channel-cells = <0>;
- };
diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
new file mode 100644
index 000000000000..8967c6f06d9d
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/sigma-delta-modulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Device-Tree bindings for sigma delta modulator
+
+maintainers:
+ - Arnaud Pouliquen <[email protected]>
+
+properties:
+ compatible:
+ description: |
+ "sd-modulator" can be used as a generic SD modulator,
+ if the modulator is not specified in the compatible list.
+ enum:
+ - sd-modulator
+ - ads1201
+
+ '#io-channel-cells':
+ const: 0
+
+required:
+ - compatible
+ - '#io-channel-cells'
+
+examples:
+ - |
+ ads1202: adc@0 {
+ compatible = "sd-modulator";
+ #io-channel-cells = <0>;
+ };
+
+...
--
2.17.1

2019-12-01 21:11:22

by Jonathan Cameron

Subject: Re: [PATCH] dt-bindings: iio: adc: convert sd modulator to json-schema

On Wed, 27 Nov 2019 18:16:42 +0100
Olivier Moysan <[email protected]> wrote:

> Convert the sigma delta modulator bindings
> to DT schema format using json-schema.
>
> Signed-off-by: Olivier Moysan <[email protected]>
Looks fine to me, but I'd like to give plenty of time for others to have
a chance to take a look.

If it looks like I've lost it in a week or two feel free to ping me.

Thanks,

Jonathan

> ---
> .../iio/adc/sigma-delta-modulator.txt | 13 -------
> .../iio/adc/sigma-delta-modulator.yaml | 35 +++++++++++++++++++
> 2 files changed, 35 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> create mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> deleted file mode 100644
> index 59b92cd32552..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -Device-Tree bindings for sigma delta modulator
> -
> -Required properties:
> -- compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
> - as a generic SD modulator if modulator not specified in compatible list.
> -- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
> -
> -Example node:
> -
> - ads1202: adc {
> - compatible = "sd-modulator";
> - #io-channel-cells = <0>;
> - };
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> new file mode 100644
> index 000000000000..8967c6f06d9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/sigma-delta-modulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Device-Tree bindings for sigma delta modulator
> +
> +maintainers:
> + - Arnaud Pouliquen <[email protected]>
> +
> +properties:
> + compatible:
> + description: |
> + "sd-modulator" can be used as a generic SD modulator,
> + if the modulator is not specified in the compatible list.
> + enum:
> + - sd-modulator
> + - ads1201
> +
> + '#io-channel-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - '#io-channel-cells'
> +
> +examples:
> + - |
> + ads1202: adc@0 {
> + compatible = "sd-modulator";
> + #io-channel-cells = <0>;
> + };
> +
> +...

2019-12-05 22:28:09

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: iio: adc: convert sd modulator to json-schema

On Wed, Nov 27, 2019 at 06:16:42PM +0100, Olivier Moysan wrote:
> Convert the sigma delta modulator bindings
> to DT schema format using json-schema.
>
> Signed-off-by: Olivier Moysan <[email protected]>
> ---
> .../iio/adc/sigma-delta-modulator.txt | 13 -------
> .../iio/adc/sigma-delta-modulator.yaml | 35 +++++++++++++++++++
> 2 files changed, 35 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> create mode 100644 Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> deleted file mode 100644
> index 59b92cd32552..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -Device-Tree bindings for sigma delta modulator
> -
> -Required properties:
> -- compatible: should be "ads1201", "sd-modulator". "sd-modulator" can be use
> - as a generic SD modulator if modulator not specified in compatible list.
> -- #io-channel-cells = <0>: See the IIO bindings section "IIO consumers".
> -
> -Example node:
> -
> - ads1202: adc {
> - compatible = "sd-modulator";
> - #io-channel-cells = <0>;
> - };
> diff --git a/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> new file mode 100644
> index 000000000000..8967c6f06d9d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/sigma-delta-modulator.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/sigma-delta-modulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Device-Tree bindings for sigma delta modulator
> +
> +maintainers:
> + - Arnaud Pouliquen <[email protected]>
> +
> +properties:
> + compatible:
> + description: |
> + "sd-modulator" can be used as a generic SD modulator,
> + if the modulator is not specified in the compatible list.
> + enum:
> + - sd-modulator
> + - ads1201
> +
> + '#io-channel-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - '#io-channel-cells'

Add:

additionalProperties: false

> +
> +examples:
> + - |
> + ads1202: adc@0 {

No reg, so drop the unit-address.

> + compatible = "sd-modulator";
> + #io-channel-cells = <0>;
> + };
> +
> +...
> --
> 2.17.1
>