2019-11-28 02:01:58

by Chuhong Yuan

Subject: [PATCH net v4] net: macb: add missed tasklet_kill

This driver forgets to kill tasklet in remove.
Add the call to fix it.

Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error")
Signed-off-by: Chuhong Yuan <[email protected]>
---
Changes in v4:
- Put tasklet_kill after unregister_netdev to ensure
IRQs are disabled when killing tasklet.

drivers/net/ethernet/cadence/macb_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index d5ae2e1e0b0e..9c767ee252ac 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4422,6 +4422,7 @@ static int macb_remove(struct platform_device *pdev)
mdiobus_free(bp->mii_bus);

unregister_netdev(dev);
+ tasklet_kill(&bp->hresp_err_tasklet);
pm_runtime_disable(&pdev->dev);
pm_runtime_dont_use_autosuspend(&pdev->dev);
if (!pm_runtime_suspended(&pdev->dev)) {
--
2.24.0

2019-11-29 07:09:55

by David Miller

Subject: Re: [PATCH net v4] net: macb: add missed tasklet_kill

From: Chuhong Yuan <[email protected]>
Date: Thu, 28 Nov 2019 10:00:21 +0800

> This driver forgets to kill tasklet in remove.
> Add the call to fix it.
>
> Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error")
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> Changes in v4:
> - Put tasklet_kill after unregister_netdev to ensure
> IRQs are disabled when killing tasklet.

Applied and queued up for -stable, thanks.