2019-11-06 09:53:09

by Wolfram Sang

[permalink] [raw]
Subject: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

Move from the deprecated i2c_new_probed_device() to the new
i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.

Signed-off-by: Wolfram Sang <[email protected]>
---

Build tested only. RFC, please comment and/or ack, but don't apply yet.

drivers/video/fbdev/matrox/i2c-matroxfb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c
index 34e2659c3189..e2e4705e3fe0 100644
--- a/drivers/video/fbdev/matrox/i2c-matroxfb.c
+++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c
@@ -191,8 +191,8 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) {
0x1b, I2C_CLIENT_END
};

- i2c_new_probed_device(&m2info->maven.adapter,
- &maven_info, addr_list, NULL);
+ i2c_new_scanned_device(&m2info->maven.adapter,
+ &maven_info, addr_list, NULL);
}
}
return m2info;
--
2.20.1


2019-11-07 08:36:20

by Daniel Vetter

[permalink] [raw]
Subject: Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote:
> Move from the deprecated i2c_new_probed_device() to the new
> i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
>
> Signed-off-by: Wolfram Sang <[email protected]>

Ack for merging through whatever tree you think this should best land
through.
-Daniel

> ---
>
> Build tested only. RFC, please comment and/or ack, but don't apply yet.
>
> drivers/video/fbdev/matrox/i2c-matroxfb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbdev/matrox/i2c-matroxfb.c
> index 34e2659c3189..e2e4705e3fe0 100644
> --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c
> +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c
> @@ -191,8 +191,8 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info* minfo) {
> 0x1b, I2C_CLIENT_END
> };
>
> - i2c_new_probed_device(&m2info->maven.adapter,
> - &maven_info, addr_list, NULL);
> + i2c_new_scanned_device(&m2info->maven.adapter,
> + &maven_info, addr_list, NULL);
> }
> }
> return m2info;
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2019-11-28 16:21:18

by Wolfram Sang

[permalink] [raw]
Subject: Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

On Thu, Nov 07, 2019 at 09:33:54AM +0100, Daniel Vetter wrote:
> On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote:
> > Move from the deprecated i2c_new_probed_device() to the new
> > i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
> >
> > Signed-off-by: Wolfram Sang <[email protected]>
>
> Ack for merging through whatever tree you think this should best land
> through.

Ok, because it is a single and simple patch, I'll apply it simply via
I2C. Thanks!


Attachments:
(No filename) (517.00 B)
signature.asc (849.00 B)
Download all attachments

2019-11-28 16:22:07

by Wolfram Sang

[permalink] [raw]
Subject: Re: [RFC PATCH 05/12] video: fbdev: matrox: convert to i2c_new_scanned_device

On Wed, Nov 06, 2019 at 10:50:23AM +0100, Wolfram Sang wrote:
> Move from the deprecated i2c_new_probed_device() to the new
> i2c_new_scanned_device(). Make use of the new ERRPTR if suitable.
>
> Signed-off-by: Wolfram Sang <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (299.00 B)
signature.asc (849.00 B)
Download all attachments