2019-11-29 11:42:26

by Stefan Mavrodiev

[permalink] [raw]

Subject: [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators

---

Allwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL. This
patch adds regulators for them to the pinctrl node.

Exception is PL which is used by the RSB bus. To avoid circular
dependencies, VCC-PL is omitted.

On boards with eMMC, VCC-PC is supplied by ELDO1, instead of DCDC1.

Signed-off-by: Stefan Mavrodiev <[email protected]>
---
.../dts/allwinner/sun50i-a64-olinuxino-emmc.dts | 4 ++++
.../boot/dts/allwinner/sun50i-a64-olinuxino.dts | 16 ++++++++++++++++
2 files changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
index 121e6cc4849b..12f8c62c4f52 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
@@ -21,3 +21,7 @@
cap-mmc-hw-reset;
status = "okay";
};
+
+&pio {
+ vcc-pc-supply = <&reg_eldo1>;
+};
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..ad3559c576dd 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,22 @@
status = "okay";
};

+&pio {
+ vcc-pc-supply = <&reg_dcdc1>;
+ vcc-pd-supply = <&reg_dcdc1>;
+ vcc-pe-supply = <&reg_aldo1>;
+ vcc-pg-supply = <&reg_dldo4>;
+};
+
+&r_pio {
+ /**
+ * Do not add vcc-pl-supply, since PL0 and PL1 are used
+ * by the RSB bus.
+ *
+ * vcc-pl-supply = <&reg_aldo2>;
+ */
+};
+
&r_rsb {
status = "okay";

--
2.17.1

2019-12-02 19:19:08

by Maxime Ripard

[permalink] [raw]

Subject: Re: [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators

---

On Fri, Nov 29, 2019 at 01:39:40PM +0200, Stefan Mavrodiev wrote:
> Allwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL. This
> patch adds regulators for them to the pinctrl node.
>
> Exception is PL which is used by the RSB bus. To avoid circular
> dependencies, VCC-PL is omitted.
>
> On boards with eMMC, VCC-PC is supplied by ELDO1, instead of DCDC1.
>
> Signed-off-by: Stefan Mavrodiev <[email protected]>

Queued for 5.6, thanks!
Maxime

---

Attachments:

(No filename) (470.00 B)
signature.asc (235.00 B)
Download all attachments