2019-12-02 13:39:14

by Amir Mizinski

[permalink] [raw]
Subject: [PATCH v2 4/5] dt-bindings: tpm: Add YAML schema for TPM TIS I2C options

From: Amir Mizinski <[email protected]>

Added a YAML schema to support tpm tis i2c realted dt-bindings for the I2c PTP based physical layer.

Signed-off-by: Amir Mizinski <[email protected]>
---
.../bindings/security/tpm/tpm-tis-i2c.yaml | 38 ++++++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml

diff --git a/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
new file mode 100644
index 0000000..bb18917
--- /dev/null
+++ b/Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0

+%YAML 1.2

+---

+$id: http://devicetree.org/schemas/security/tpm/tpm-tis-i2c.yaml#

+$schema: http://devicetree.org/meta-schemas/core.yaml#

+

+title: I2C PTP based TPM Device Tree Bindings

+

+maintainers:

+ - Amir Mizinski <[email protected]>

+

+description:

+ The TCG defines hardware protocol, registers and interface (based

+ on the TPM Interface Specification) for accessing TPM devices

+ implemented with an I2C interface.

+ Refer to the 'I2C Interface Definition' section in 'TCG PC Client

+ PlatformTPMProfile(PTP) Specification' publication for specification.

+ Designed for Raspberry Pie 3 Board with Nuvoton's NPCT75X (2.0)

+

+properties:

+ compatible:

+ contains:

+ const: tcg,tpm-tis-i2c

+

+ reg:

+ maxItems: 1

+

+required:

+ - compatible

+ - reg

+

+

+examples:

+ - |

+ tpm-tis-i2c: tpm-tis-i2c@2e {

+ compatible = "tcg,tpm-tis-i2c";

+ reg = <0x2e>;

+ };

--
2.7.4


2019-12-13 22:37:19

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 4/5] dt-bindings: tpm: Add YAML schema for TPM TIS I2C options

On Mon, Dec 02, 2019 at 03:33:31PM +0200, [email protected] wrote:
> From: Amir Mizinski <[email protected]>
>
> Added a YAML schema to support tpm tis i2c realted dt-bindings for the I2c PTP based physical layer.

Wrap your commmit message. And TPM, TIS?, and I2C should be capitalized.

>
> Signed-off-by: Amir Mizinski <[email protected]>
> ---
> .../bindings/security/tpm/tpm-tis-i2c.yaml | 38 ++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml

Please read my comments on v1 (The first v1 from 11/10, not the 2nd v1
you sent).

Rob