2019-12-04 11:50:02

by Mihail Atanassov

Subject: [PATCH v2 26/28] drm: rcar-du: lvds: Don't set drm_bridge private pointer

No functional change: it's not used anywhere.

Signed-off-by: Mihail Atanassov <[email protected]>
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index ac1f29bacfcb..168a718cbcbd 100644
--- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
+++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
@@ -882,7 +882,7 @@ static int rcar_lvds_probe(struct platform_device *pdev)
return ret;

drm_bridge_init(&lvds->bridge, &pdev->dev, &rcar_lvds_bridge_ops,
- NULL, lvds);
+ NULL, NULL);

mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);
--
2.23.0

2019-12-05 13:33:20

by Laurent Pinchart

Subject: Re: [PATCH v2 26/28] drm: rcar-du: lvds: Don't set drm_bridge private pointer

Hi Mihail,

Thank you for the patch.

On Wed, Dec 04, 2019 at 11:48:24AM +0000, Mihail Atanassov wrote:
> No functional change: it's not used anywhere.
>
> Signed-off-by: Mihail Atanassov <[email protected]>
> ---
> drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index ac1f29bacfcb..168a718cbcbd 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -882,7 +882,7 @@ static int rcar_lvds_probe(struct platform_device *pdev)
> return ret;
>
> drm_bridge_init(&lvds->bridge, &pdev->dev, &rcar_lvds_bridge_ops,
> - NULL, lvds);
> + NULL, NULL);

You can squash this with 25/28.

>
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> lvds->mmio = devm_ioremap_resource(&pdev->dev, mem);

--
Regards,

Laurent Pinchart