2019-12-05 14:01:21

by Rodrigo Siqueira Jordao

Subject: [PATCH] drm: Add FEC registers for LT-tunable repeaters

FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP
1.4a. This commit adds the address registers for
FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1.

Cc: Abdoulaye Berthe <[email protected]>
Cc: Harry Wentland <[email protected]>
Cc: Leo Li <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Manasi Navare <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Signed-off-by: Abdoulaye Berthe <[email protected]>
Signed-off-by: Rodrigo Siqueira <[email protected]>
---
include/drm/drm_dp_helper.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 51ecb5112ef8..b2057009aabc 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -1042,6 +1042,8 @@
#define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1 0xf0039 /* 1.3 */
#define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
#define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
+#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /* 1.4 */
+#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a */

/* Repeater modes */
#define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
--
2.24.0

2019-12-05 15:29:02

by Liu, Zhan

Subject: RE: [PATCH] drm: Add FEC registers for LT-tunable repeaters

> -----Original Message-----
> From: amd-gfx <[email protected]> On Behalf Of
> Rodrigo Siqueira
> Sent: 2019/December/05, Thursday 8:59 AM
> To: [email protected]; [email protected]; amd-
> [email protected]
> Cc: Li, Sun peng (Leo) <[email protected]>; Berthe, Abdoulaye
> <[email protected]>; Jani Nikula <[email protected]>;
> Cornij, Nikola <[email protected]>; Manasi Navare
> <[email protected]>; Wentland, Harry
> <[email protected]>; Ville Syrjälä <[email protected]>
> Subject: [PATCH] drm: Add FEC registers for LT-tunable repeaters
>
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP 1.4a.
> This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and
> FEC_CAPABILITY_PHY_REPEATER1.
>
> Cc: Abdoulaye Berthe <[email protected]>
> Cc: Harry Wentland <[email protected]>
> Cc: Leo Li <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: Manasi Navare <[email protected]>
> Cc: Ville Syrjälä <[email protected]>
> Signed-off-by: Abdoulaye Berthe <[email protected]>
> Signed-off-by: Rodrigo Siqueira <[email protected]>

Looks good to me.
Reviewed-by: Zhan Liu <[email protected]>

> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1
> 0xf0039 /* 1.3 */
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1
> 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /*
> 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /*
> 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a
> */
>
> /* Repeater modes */
> #define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /*
> 1.3 */
> --
> 2.24.0
>
> _______________________________________________
> amd-gfx mailing list
> [email protected]
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=02%7C01%7Czhan.liu%40amd.com%7Cfdbf92dcf79449d434e
> 208d7798b586d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> 37111511793172919&amp;sdata=SXDkgEpIQmTkmfFL0bXSBFwVxd9sSMWke
> V358fkkQZY%3D&amp;reserved=0

2019-12-06 16:40:15

by Harry Wentland

Subject: Re: [PATCH] drm: Add FEC registers for LT-tunable repeaters

On 2019-12-05 8:58 a.m., Rodrigo Siqueira wrote:
> FEC is supported since DP 1.4, and it was expanded for LT-tunable in DP
> 1.4a. This commit adds the address registers for
> FEC_ERROR_COUNT_PHY_REPEATER1 and FEC_CAPABILITY_PHY_REPEATER1.
>
> Cc: Abdoulaye Berthe <[email protected]>
> Cc: Harry Wentland <[email protected]>
> Cc: Leo Li <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: Manasi Navare <[email protected]>
> Cc: Ville Syrjälä <[email protected]>
> Signed-off-by: Abdoulaye Berthe <[email protected]>
> Signed-off-by: Rodrigo Siqueira <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 51ecb5112ef8..b2057009aabc 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -1042,6 +1042,8 @@
> #define DP_SYMBOL_ERROR_COUNT_LANE2_PHY_REPEATER1 0xf0039 /* 1.3 */
> #define DP_SYMBOL_ERROR_COUNT_LANE3_PHY_REPEATER1 0xf003b /* 1.3 */
> #define DP_FEC_STATUS_PHY_REPEATER1 0xf0290 /* 1.4 */
> +#define DP_FEC_ERROR_COUNT_PHY_REPEATER1 0xf0291 /* 1.4 */
> +#define DP_FEC_CAPABILITY_PHY_REPEATER1 0xf0294 /* 1.4a */
>
> /* Repeater modes */
> #define DP_PHY_REPEATER_MODE_TRANSPARENT 0x55 /* 1.3 */
>