This patch corrects the SPDX License Identifier style
in the pinctrl driver related files.
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46
and some manual changes.
Nishad Kamdar (5):
pinctrl: actions: Use the correct style for SPDX License Identifier
pinctrl: mediatek: Use the correct style for SPDX License Identifier
pinctrl: meson-axg: Use the correct style for SPDX License Identifier
pinctrl: sh-pfc: Use the correct style for SPDX License Identifier
pinctrl: stm32: Use the correct style for SPDX License Identifier
drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 2 +-
drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h | 2 +-
drivers/pinctrl/sh-pfc/core.h | 4 ++--
drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
drivers/pinctrl/stm32/pinctrl-stm32.h | 2 +-
6 files changed, 8 insertions(+), 8 deletions(-)
--
2.17.1
This patch corrects the SPDX License Identifier style in
header file related Actions Semi OWL pinctrl driver.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
index dae2e8363fd5..feee7ad7e27e 100644
--- a/drivers/pinctrl/actions/pinctrl-owl.h
+++ b/drivers/pinctrl/actions/pinctrl-owl.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
/*
* OWL SoC's Pinctrl definitions
*
--
2.17.1
This patch corrects the SPDX License Identifier style in
header file related mediatek mt2712 pinctrl driver.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h
index ba2356a8ab89..845c408b5fdb 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-mt2712.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) 2018 MediaTek Inc.
* Author: Zhiyong Tao <[email protected]>
--
2.17.1
This patch corrects the SPDX License Identifier style in
header file related Meson axg SoC pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h b/drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h
index 8ff88bf2e849..aa79d7ecee00 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h
+++ b/drivers/pinctrl/meson/pinctrl-meson-axg-pmx.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */
/*
* Copyright (c) 2017 Baylibre SAS.
* Author: Jerome Brunet <[email protected]>
@@ -5,7 +6,6 @@
* Copyright (c) 2017 Amlogic, Inc. All rights reserved.
* Author: Xingyu Chen <[email protected]>
*
- * SPDX-License-Identifier: (GPL-2.0+ or MIT)
*/
struct meson_pmx_bank {
--
2.17.1
This patch corrects the SPDX License Identifier style in
header files related to Reneses Soc pinctrl driver.
It assigns explicit block comment for the SPDX License Identifier.
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/pinctrl/sh-pfc/core.h | 4 ++--
drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
index b5b1d163e98a..5ad0ab8f9e14 100644
--- a/drivers/pinctrl/sh-pfc/core.h
+++ b/drivers/pinctrl/sh-pfc/core.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: GPL-2.0
- *
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
* SuperH Pin Function Controller support.
*
* Copyright (C) 2012 Renesas Solutions Corp.
diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
index 640d2a4cb838..fff9cbb7a0f8 100644
--- a/drivers/pinctrl/sh-pfc/sh_pfc.h
+++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
@@ -1,5 +1,5 @@
-/* SPDX-License-Identifier: GPL-2.0
- *
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
* SuperH Pin Function Controller Support
*
* Copyright (c) 2008 Magnus Damm
--
2.17.1
This patch corrects the SPDX License Identifier style in
header file related to STMicroelectronics pinctrl driver.
For C header files Documentation/process/license-rules.rst
mandates C-like comments (opposed to C source files where
C++ style should be used).
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Nishad Kamdar <[email protected]>
---
drivers/pinctrl/stm32/pinctrl-stm32.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.h b/drivers/pinctrl/stm32/pinctrl-stm32.h
index ec0d34c33903..b0882d120765 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32.h
+++ b/drivers/pinctrl/stm32/pinctrl-stm32.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright (C) Maxime Coquelin 2015
* Copyright (C) STMicroelectronics 2017
--
2.17.1
On Wed, Nov 27, 2019 at 9:59 PM Joe Perches <[email protected]> wrote:
> On Wed, 2019-11-27 at 21:55 +0100, Andreas Färber wrote:
> > However, if we're touching these lines anyway, shouldn't we be updating
> > the SPDX Identifier to GPL-2.0-only while at it?
>
> Probably better to do that with a treewide script one day.
Yeah... But it's already more than one year after
> https://lkml.org/lkml/2018/8/16/487
and Documentation/process/license-rules.rst (which is the authoritive
rule?) still hasn't been updated...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
> This patch corrects the SPDX License Identifier style in
> header file related Actions Semi OWL pinctrl driver.
Owl
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
> ---
> drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
> index dae2e8363fd5..feee7ad7e27e 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.h
> +++ b/drivers/pinctrl/actions/pinctrl-owl.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0+
> +/* SPDX-License-Identifier: GPL-2.0+ */
This is not a uapi or asm header, which that /* */ rule was later added
for, I thought?
> /*
> * OWL SoC's Pinctrl definitions
> *
Not objecting, just making sure we're not blindly refactoring code.
If doing this, I suggest updating to GPL-2.0-or-later.
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
On Wed, 2019-11-27 at 21:55 +0100, Andreas F?rber wrote:
> However, if we're touching these lines anyway, shouldn't we be updating
> the SPDX Identifier to GPL-2.0-only while at it?
Probably better to do that with a treewide script one day.
https://lkml.org/lkml/2018/8/16/487
Hi Geert,
Am 27.11.19 um 21:37 schrieb Geert Uytterhoeven:
> On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <[email protected]> wrote:
>> This patch corrects the SPDX License Identifier style in
>> header files related to Reneses Soc pinctrl driver.
>> It assigns explicit block comment for the SPDX License Identifier.
>
> Is it incorrect to not have an explicit block comment?
Yes, Greg said so to me. He suggested I provide a patch against the
documentation if the docs are not clear enough, but I didn't get around
to it (and it's not my rule in the first place, so I'd appreciate the
person making that rule to take care of documenting it).
However, if we're touching these lines anyway, shouldn't we be updating
the SPDX Identifier to GPL-2.0-only while at it?
Cheers,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
On Wed, 2019-11-27 at 22:12 +0100, Geert Uytterhoeven wrote:
> On Wed, Nov 27, 2019 at 9:59 PM Joe Perches <[email protected]> wrote:
> > On Wed, 2019-11-27 at 21:55 +0100, Andreas F?rber wrote:
> > > However, if we're touching these lines anyway, shouldn't we be updating
> > > the SPDX Identifier to GPL-2.0-only while at it?
> >
> > Probably better to do that with a treewide script one day.
>
> Yeah... But it's already more than one year after
>
> > https://lkml.org/lkml/2018/8/16/487
>
> and Documentation/process/license-rules.rst (which is the authoritive
> rule?) still hasn't been updated...
The patch still applies today...
Hi Nishad,
On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <[email protected]> wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
Is it incorrect to not have an explicit block comment?
Other recommendations have been to integrate the SPDX comment line
into an existing comment header, if it exists....
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
> ---
> drivers/pinctrl/sh-pfc/core.h | 4 ++--
> drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/core.h b/drivers/pinctrl/sh-pfc/core.h
> index b5b1d163e98a..5ad0ab8f9e14 100644
> --- a/drivers/pinctrl/sh-pfc/core.h
> +++ b/drivers/pinctrl/sh-pfc/core.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller support.
> *
> * Copyright (C) 2012 Renesas Solutions Corp.
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 640d2a4cb838..fff9cbb7a0f8 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -1,5 +1,5 @@
> -/* SPDX-License-Identifier: GPL-2.0
> - *
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> * SuperH Pin Function Controller Support
> *
> * Copyright (c) 2008 Magnus Damm
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Wed, Nov 27, 2019 at 10:02:08PM +0100, Andreas Färber wrote:
> Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
> > This patch corrects the SPDX License Identifier style in
> > header file related Actions Semi OWL pinctrl driver.
>
> Owl
>
I used the same format mentioned below, which also says OWL.
Meybe we can change both of them in a separate patch.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used).
> >
> > Changes made by using a script provided by Joe Perches here:
> > https://lkml.org/lkml/2019/2/7/46.
> >
> > Suggested-by: Joe Perches <[email protected]>
> > Signed-off-by: Nishad Kamdar <[email protected]>
> > ---
> > drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
> > index dae2e8363fd5..feee7ad7e27e 100644
> > --- a/drivers/pinctrl/actions/pinctrl-owl.h
> > +++ b/drivers/pinctrl/actions/pinctrl-owl.h
> > @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0+
> > +/* SPDX-License-Identifier: GPL-2.0+ */
>
> This is not a uapi or asm header, which that /* */ rule was later added
> for, I thought?
>
I might be wrong but I think it applies to this file too as there as there is a SPDX
identifier in the first place.
> > /*
> > * OWL SoC's Pinctrl definitions
> > *
>
> Not objecting, just making sure we're not blindly refactoring code.
>
I am not sure what you are trying to say here, but the SPDX identifier
requires an independent block comment. Hence placed the obove code in a
separate block comment. Everything else is as it is.
> If doing this, I suggest updating to GPL-2.0-or-later.
>
We can do this in a separate patch as this patch only talks about
the style.
> Regards,
> Andreas
>
> --
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)
Thanks very much for your time and review.
Regards,
Nishad
On Wed, Nov 27, 2019 at 5:42 PM Nishad Kamdar <[email protected]> wrote:
> This patch corrects the SPDX License Identifier style in
> header file related mediatek mt2712 pinctrl driver.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
Patch applied.
Yours,
Linus Walleij
On Wed, Nov 27, 2019 at 5:46 PM Nishad Kamdar <[email protected]> wrote:
> This patch corrects the SPDX License Identifier style in
> header files related to Reneses Soc pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
I leave it to Geert to decide if he wants to pick this up for
sh-pfc or not.
Yours,
Linus Walleij
On Wed, Nov 27, 2019 at 5:47 PM Nishad Kamdar <[email protected]> wrote:
> This patch corrects the SPDX License Identifier style in
> header file related to STMicroelectronics pinctrl driver.
> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
Patch applied.
Yours,
Linus Walleij
On Wed, Nov 27, 2019 at 5:44 PM Nishad Kamdar <[email protected]> wrote:
> This patch corrects the SPDX License Identifier style in
> header file related Meson axg SoC pinctrl driver.
> It assigns explicit block comment for the SPDX License Identifier.
>
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Nishad Kamdar <[email protected]>
Patch applied.
Yours,
Linus Walleij