2019-12-05 16:09:24

by Matheus Castello

[permalink] [raw]
Subject: [PATCH v8 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes

This series add IRQ handler for low level SOC alert, define a devicetree
binding attribute to configure the alert level threshold and check for
changes in SOC and power supply status for send uevents.

Max17043/17044 have a pin for alert host about low level state of charge and
this alert can be configured in a threshold from 1% up to 32% of SOC.

Thanks Krzysztof Kozlowski, Lee Jones, Rob Herring and Sebastian Reichel for
your time reviewing it.

Changes since v7:
(Suggested by Sebastian Reichel)
- Fix unrelated change
- Use device_property_read_u32() and simplify the code
- Check the irq and of_device_is_compatible in the first patch

Changes since v6:
(Suggested by Lee Jones)
- Use relative paths in documentation

Matheus Castello (5):
power: supply: max17040: Add IRQ handler for low SOC alert
dt-bindings: power: supply: Max17040: Add DT bindings for max17040
fuel gauge
devicetree: mfd: max14577: Add reference to max14040_battery.txt
descriptions
power: supply: max17040: Config alert SOC low level threshold from FDT
power: supply: max17040: Send uevent in SOC and status change

.../devicetree/bindings/mfd/max14577.txt | 2 +
.../power/supply/max17040_battery.txt | 33 +++++
drivers/power/supply/max17040_battery.c | 130 +++++++++++++++++-
3 files changed, 161 insertions(+), 4 deletions(-)
create mode 100644 Documentation/devicetree/bindings/power/supply/max17040_battery.txt

--
2.24.0.rc2


2019-12-05 16:10:42

by Matheus Castello

[permalink] [raw]
Subject: [PATCH v8 3/5] devicetree: mfd: max14577: Add reference to max14040_battery.txt descriptions

max77836 MFD has a fuel gauge that has a low SOC alert feature that is
described in Documentation/devicetree/bindings/power/supply/max17040_battery.txt.
Adding the reference to de documentation here.

Signed-off-by: Matheus Castello <[email protected]>
Acked-by: Lee Jones <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/mfd/max14577.txt | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt
index fc6f0f4e8beb..45c7f414aee0 100644
--- a/Documentation/devicetree/bindings/mfd/max14577.txt
+++ b/Documentation/devicetree/bindings/mfd/max14577.txt
@@ -5,6 +5,8 @@ Battery Charger and SFOUT LDO output for powering USB devices. It is
interfaced to host controller using I2C.

MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge.
+For the description of Fuel Gauge low SOC alert interrupt see:
+power/supply/max17040_battery.txt


Required properties:
--
2.24.0.rc2

2019-12-06 09:16:53

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v8 3/5] devicetree: mfd: max14577: Add reference to max14040_battery.txt descriptions

On Thu, Dec 05, 2019 at 12:44:08PM -0300, Matheus Castello wrote:
> max77836 MFD has a fuel gauge that has a low SOC alert feature that is
> described in Documentation/devicetree/bindings/power/supply/max17040_battery.txt.
> Adding the reference to de documentation here.

The subject prefix should be:
dt-bindings: mfd: max14577: ...

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


>
> Signed-off-by: Matheus Castello <[email protected]>
> Acked-by: Lee Jones <[email protected]>
> Acked-by: Rob Herring <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/max14577.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt
> index fc6f0f4e8beb..45c7f414aee0 100644
> --- a/Documentation/devicetree/bindings/mfd/max14577.txt
> +++ b/Documentation/devicetree/bindings/mfd/max14577.txt
> @@ -5,6 +5,8 @@ Battery Charger and SFOUT LDO output for powering USB devices. It is
> interfaced to host controller using I2C.
>
> MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge.
> +For the description of Fuel Gauge low SOC alert interrupt see:
> +power/supply/max17040_battery.txt
>
>
> Required properties:
> --
> 2.24.0.rc2
>

2019-12-19 00:53:44

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH v8 0/5] power: supply: MAX17040: Add IRQ for low level and alert SOC changes

Hi,

On Thu, Dec 05, 2019 at 12:44:05PM -0300, Matheus Castello wrote:
> This series add IRQ handler for low level SOC alert, define a devicetree
> binding attribute to configure the alert level threshold and check for
> changes in SOC and power supply status for send uevents.
>
> Max17043/17044 have a pin for alert host about low level state of charge and
> this alert can be configured in a threshold from 1% up to 32% of SOC.
>
> Thanks Krzysztof Kozlowski, Lee Jones, Rob Herring and Sebastian Reichel for
> your time reviewing it.

Thanks, I queued all but the MFD patch to power-supply's for-next
branch.

-- Sebastian

> Changes since v7:
> (Suggested by Sebastian Reichel)
> - Fix unrelated change
> - Use device_property_read_u32() and simplify the code
> - Check the irq and of_device_is_compatible in the first patch
>
> Changes since v6:
> (Suggested by Lee Jones)
> - Use relative paths in documentation
>
> Matheus Castello (5):
> power: supply: max17040: Add IRQ handler for low SOC alert
> dt-bindings: power: supply: Max17040: Add DT bindings for max17040
> fuel gauge
> devicetree: mfd: max14577: Add reference to max14040_battery.txt
> descriptions
> power: supply: max17040: Config alert SOC low level threshold from FDT
> power: supply: max17040: Send uevent in SOC and status change
>
> .../devicetree/bindings/mfd/max14577.txt | 2 +
> .../power/supply/max17040_battery.txt | 33 +++++
> drivers/power/supply/max17040_battery.c | 130 +++++++++++++++++-
> 3 files changed, 161 insertions(+), 4 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/power/supply/max17040_battery.txt
>
> --
> 2.24.0.rc2
>


Attachments:
(No filename) (1.70 kB)
signature.asc (849.00 B)
Download all attachments