2019-12-05 23:43:34

by Aditya Pakki

Subject: [PATCH] drm/qxl: remove unnecessary BUG_ON check for handle

In qxl_gem_object_create_with_handle(), handle's memory is not
allocated on the heap. Checking for failure of handle via BUG_ON
is unnecessary. This patch eliminates the check.

Signed-off-by: Aditya Pakki <[email protected]>
---
drivers/gpu/drm/qxl/qxl_gem.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/qxl/qxl_gem.c b/drivers/gpu/drm/qxl/qxl_gem.c
index 69f37db1027a..45b779a8bc22 100644
--- a/drivers/gpu/drm/qxl/qxl_gem.c
+++ b/drivers/gpu/drm/qxl/qxl_gem.c
@@ -84,7 +84,6 @@ int qxl_gem_object_create_with_handle(struct qxl_device *qdev,
int r;

BUG_ON(!qobj);
- BUG_ON(!handle);

r = qxl_gem_object_create(qdev, size, 0,
domain,
--
2.17.1

2019-12-06 10:14:35

by Gerd Hoffmann

Subject: Re: [PATCH] drm/qxl: remove unnecessary BUG_ON check for handle

On Thu, Dec 05, 2019 at 05:42:31PM -0600, Aditya Pakki wrote:
> In qxl_gem_object_create_with_handle(), handle's memory is not
> allocated on the heap. Checking for failure of handle via BUG_ON
> is unnecessary. This patch eliminates the check.

The check makes sure the caller doesn't pass in handle == NULL
and it is needed.

cheers,
Gerd